Add searchbox, add it to mod panel and dynos panel#1129
Draft
EmeraldLoc wants to merge 6 commits intocoop-deluxe:devfrom
Draft
Add searchbox, add it to mod panel and dynos panel#1129EmeraldLoc wants to merge 6 commits intocoop-deluxe:devfrom
EmeraldLoc wants to merge 6 commits intocoop-deluxe:devfrom
Conversation
This was referenced Mar 1, 2026
Contributor
Author
|
I need translations for this item, then this pr will be ready to merge |
Contributor
|
German: SEARCH = "Suche..." |
Contributor
Author
|
I added in translations via the other search text. If there are any issues, lmk, but this should be good to merge |
Isaac0-dev
reviewed
Mar 10, 2026
| if (!dynos_pack_get_exists(i)) continue; | ||
| bool tmp = dynos_pack_get_enabled(i); | ||
| const char* pack = dynos_pack_get_name(i); | ||
| if (sSearchInputbox != NULL && sSearchInputbox->buffer != NULL && !strcasestr(djui_text_get_uncolored_string(NULL, strlen(pack) + 1, pack), sSearchInputbox->buffer)) continue; |
Contributor
There was a problem hiding this comment.
Just some reformatting and a comment.
Suggested change
| if (sSearchInputbox != NULL && sSearchInputbox->buffer != NULL && !strcasestr(djui_text_get_uncolored_string(NULL, strlen(pack) + 1, pack), sSearchInputbox->buffer)) continue; | |
| // Filter results | |
| if (sSearchInputbox != NULL && | |
| sSearchInputbox->buffer != NULL && | |
| !strcasestr(djui_text_get_uncolored_string(NULL, strlen(pack) + 1, pack), sSearchInputbox->buffer) | |
| ) { | |
| continue; | |
| } |
Contributor
Author
There was a problem hiding this comment.
Should there really be a space for pointers?
Comment on lines
+161
to
+163
| if (sSearchInputbox != NULL && sSearchInputbox->buffer != NULL && !strcasestr(djui_text_get_uncolored_string(NULL, strlen(mod->name) + 1, mod->name), sSearchInputbox->buffer)) { | ||
| continue; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (sSearchInputbox != NULL && sSearchInputbox->buffer != NULL && !strcasestr(djui_text_get_uncolored_string(NULL, strlen(mod->name) + 1, mod->name), sSearchInputbox->buffer)) { | |
| continue; | |
| } | |
| if (sSearchInputbox != NULL && | |
| sSearchInputbox->buffer != NULL && | |
| !strcasestr(djui_text_get_uncolored_string(NULL, strlen(mod->name) + 1, mod->name), sSearchInputbox->buffer) | |
| ) { | |
| continue; | |
| } |
Contributor
Author
There was a problem hiding this comment.
Should there really be a space for pointers?
Contributor
Author
|
My new plan is to have all of the pr's merged, then update this one to add the searchbar to all of them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty much title, here's a pic of what it looks like
Something to note though is I had to redo some of the input box stuff relating to theming. This means the chatbox now looks like this
If need be, and depending on feedback, I can revert the theming changes for the chatbox specifically.
Other input boxes related to theming have been changed aswell by side effect, but these look nice so I don't see a reason to revert it. It's proper now.