[template.bitset.general][vector.bool.pspc] Make subclauses for reference nested classes#8661
[template.bitset.general][vector.bool.pspc] Make subclauses for reference nested classes#8661AlisdairM wants to merge 2 commits intocplusplus:mainfrom
reference nested classes#8661Conversation
|
Can you make this two commits please (keep them in this single pull request)? |
AlisdairM
force-pushed
the
create_subclause_for_reference_types
branch
4 times, most recently
from
2f838c5 to
afa9ade
Compare
|
Split into two commits, making the requested change to separate out the template-head in each case. |
AlisdairM
force-pushed
the
create_subclause_for_reference_types
branch
from
afa9ade to
a138504
Compare
|
The commit descriptions (in particular the titles) aren't stellar. "Break out into its own subclause" is missing "reference" and/or "nested class" somewhere. In particular since the new label is [vector.bool.reference], not the quoted label. |
|
It looks like my git command line mangled my attempts to put the class names into the commit title line. I will fix just those commit messages and resubmit. |
…subclause This change is consistent with specification of nested classes elsewhere in the standard, and allows better use of qualified names in the declaration of member functions in their own specification.
…ubclause This change is consistent with specification of nested classes elsewhere in the standard, and allows better use of qualified names in the declaration of member functions in their own specification.
AlisdairM
force-pushed
the
create_subclause_for_reference_types
branch
from
a138504 to
c9a4561
Compare
|
This seemingly addresses #5904. CC @blackteahamburger. |
Yes, thanks. |
| \tcode{reference} | ||
| is a class that simulates a reference to a single bit in the sequence. |
There was a problem hiding this comment.
Can we also reword this the same as you did below ("Class reference simulates...")? It's awkward to start a sentence with a symbol.
tkoeppe
added
the
changes requested
5 participants
Consistent with other nested classes within the standard library. This formulation leads to slightly clearer specification for the member functions that now use appropriately qualified names.