Skip to content

[WIP] Issue #134 — ENABLE_DEVELOPER_MODE is still relevant?#144

Merged
lefticus merged 2 commits intocpp-best-practices:mainfrom
leftibot:fix/issue-134-enable-developer-mode-is-still-relevant
Apr 12, 2026
Merged

[WIP] Issue #134 — ENABLE_DEVELOPER_MODE is still relevant?#144
lefticus merged 2 commits intocpp-best-practices:mainfrom
leftibot:fix/issue-134-enable-developer-mode-is-still-relevant

Conversation

@leftibot
Copy link
Copy Markdown
Contributor

@leftibot leftibot commented Apr 11, 2026

Automated attempt by @leftibot. Opening as draft — verification failed.

Reason: no test files were detected in the diff

What changed

Fix #134: Remove dead ENABLE_DEVELOPER_MODE variable
ENABLE_DEVELOPER_MODE was set in CMakePresets.json but never read by any
CMake file — a leftover from when the project consumed aminya/project_options.
Removed it from all presets, consolidated the duplicate developer-mode/user-mode
Windows MSVC presets into single debug/release presets, updated the README, and
added a configuration-time guard that rejects the variable with a helpful message.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Files

 CMakePresets.json    | 46 ++++++++++------------------------------------
 ProjectOptions.cmake |  8 ++++++++
 README.md            |  2 +-
 3 files changed, 19 insertions(+), 37 deletions(-)

Will close #134 once finalized.

Triggered by @lefticus.

@leftibot @claude
Fix cpp-best-practices#134: Remove dead ENABLE_DEVELOPER_MODE variable
48f0d76 
ENABLE_DEVELOPER_MODE was set in CMakePresets.json but never read by any
CMake file — a leftover from when the project consumed aminya/project_options.
Removed it from all presets, consolidated the duplicate developer-mode/user-mode
Windows MSVC presets into single debug/release presets, updated the README, and
added a configuration-time guard that rejects the variable with a helpful message.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.50%. Comparing base (12e3e37) to head (cde9dbb).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   20.50%   20.50%           
=======================================
  Files           5        5           
  Lines         239      239           
  Branches      108      110    +2     
=======================================
  Hits           49       49           
+ Misses        186      181    -5     
- Partials        4        9    +5
Flag Coverage Δ
Linux 18.36% <ø> (ø)
Windows 21.02% <ø> (ø)
macOS 18.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lefticus
lefticus reviewed Apr 12, 2026
View reviewed changes
ProjectOptions.cmake Outdated
endmacro()

macro(myproject_setup_options)
if(DEFINED ENABLE_DEVELOPER_MODE)
Copy link
Copy Markdown
Member

@lefticus lefticus Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leftibot this check is unnecessary, remove it.

Copy link
Copy Markdown
Member

@lefticus lefticus Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leftibot remove the check for ENABLE_DEVELOPER_MODE here

@leftibot @claude
Address review: remove ENABLE_DEVELOPER_MODE guard from ProjectOption…
cde9dbb 
…s.cmake

Requested by @lefticus in PR cpp-best-practices#144 review.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@leftibot
Copy link
Copy Markdown
Contributor Author

leftibot commented Apr 12, 2026

Addressed review feedback from @lefticus. New commits:

cde9dbb Address review: remove ENABLE_DEVELOPER_MODE guard from ProjectOptions.cmake

@lefticus lefticus marked this pull request as ready for review April 12, 2026 21:35
@lefticus lefticus merged commit e73ce38 into cpp-best-practices:main Apr 12, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lefticus lefticus lefticus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ENABLE_DEVELOPER_MODE is still relevant?

2 participants

@leftibot @lefticus