expose aiohttp request to @webhook_trigger functions#842
Merged
craigbarratt merged 3 commits intoMay 11, 2026
Conversation
Add the underlying aiohttp.web.Request to the kwargs passed to @webhook_trigger user functions (and to the str_expr filter). Lets scripts inspect headers, method, query string, and re-read the raw body via `await request.read()` -- enabling HMAC signature validation, which previously wasn't possible since only the parsed payload was exposed. Backward compatible: existing functions that don't declare `request` are unaffected.
Member
|
Thanks for the PR. Can you also update |
Contributor
Author
|
Thanks for the review -- updated. |
Contributor
Author
|
The alternative here is to add |
Contributor
Author
|
I guess another alternative to solve my use case would be to add params to the webhook trigger annotation for the webhook secret and header name. Given those the validation could happen inside the pyscript code. But maybe that's too involved on the pyscript side. |
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the underlying aiohttp.web.Request to the kwargs passed to @webhook_trigger user functions (and to the str_expr filter). Lets scripts inspect headers, method, query string, and re-read the raw body via
await request.read()-- enabling HMAC signature validation, which previously wasn't possible since only the parsed payload was exposed.Backward compatible: existing functions that don't declare
requestare unaffected.