Skip to content

feat: Added $distinct parameter to SelectQuery::count #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roxblnfk merged 2 commits into from
Mar 19, 2026
Merged

feat: Added $distinct parameter to SelectQuery::count #242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c55d64
feat: Added $distinct parameter to SelectQuery::count
bbldn Feb 28, 2026
724df7f
Added an extra test to cover all syntaxes
bbldn Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Query/SelectQuery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,12 +326,14 @@ public function runChunks(int $limit, callable $callback): void
*
* @psalm-param non-empty-string $column Column to count by (every column by default).
*/
public function count(string $column = '*'): int
public function count(string $column = '*', bool $distinct = false): int
{
$select = clone $this;

//To be escaped in compiler
$select->columns = ["COUNT({$column})"];
$select->columns = [
$distinct === true ? "COUNT(DISTINCT({$column}))" : "COUNT({$column})",
];
$select->orderBy = [];
$select->groupBy = [];

Expand Down
2 changes: 1 addition & 1 deletion tests/Database/Functional/Driver/Common/Schema/TableTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ public function testCountDistinct(): void
],
);

$this->assertSame(4, $table->select()->count('DISTINCT(id)'));
$this->assertSame(4, $table->select()->count('id', true));
Copy link
Copy Markdown
Member

@roxblnfk roxblnfk Mar 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test it in a new function. The both cases should be covered

Copy link
Copy Markdown
Contributor Author

@bbldn bbldn Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

}

public function setUp(): void
Expand Down
Loading