chore(release): update changelog and bump version to 4.0.0-beta.1#3779
Conversation
|
Warning Review limit reached
More reviews will be available in 15 minutes and 45 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughVersion 4.0.0-beta.1 release coordinated by updating CHANGELOG.md with release notes, bumping workspace and root package versions from 3.1.0-dev.8 to 4.0.0-beta.1 in Cargo.toml and root package.json, and synchronizing version strings across 22 workspace package manifests. ChangesRelease Version Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Review complete (commit 3573f4e) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 1: The changelog entry header contains a malformed compare URL "##
[4.0.0-beta.1](///compare/v3.1.0-dev.8...v4.0.0-beta.1) (2026-06-02)"; replace
the leading "///compare/..." with the full repository compare URL used by other
entries (e.g.
"https://github.com/<org>/<repo>/compare/v3.1.0-dev.8...v4.0.0-beta.1") so the
link resolves correctly while keeping the rest of the header text intact.
- Around line 6-27: The CHANGELOG.md contains broken issue links using the
placeholder base "undefined/undefined/undefined" (e.g. the patterns like
([`#3744`](undefined/undefined/undefined/issues/3744))); update each broken link
to point to the correct GitHub URL for this repository (replace the
undefined/undefined/undefined base with the repo's real org/name path or a full
https://github.com/<ORG>/<REPO>/pull/<PR#> or /issues/<#> URL), and ensure every
occurrence (all instances shown: `#3744`, `#3764`, `#3774`, `#3725`, `#3769`, `#3732`,
`#3162`, `#3461`, `#3165`, `#3742`, `#3596`, `#3479`, `#3771`) is fixed consistently so the
markdown links resolve.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7a5eea34-eba0-4269-a142-aa71f1056ac9
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (25)
CHANGELOG.mdCargo.tomlpackage.jsonpackages/bench-suite/package.jsonpackages/dapi-grpc/package.jsonpackages/dapi/package.jsonpackages/dash-spv/package.jsonpackages/dashmate/package.jsonpackages/dashpay-contract/package.jsonpackages/dpns-contract/package.jsonpackages/js-dapi-client/package.jsonpackages/js-dash-sdk/package.jsonpackages/js-evo-sdk/package.jsonpackages/js-grpc-common/package.jsonpackages/keyword-search-contract/package.jsonpackages/masternode-reward-shares-contract/package.jsonpackages/platform-test-suite/package.jsonpackages/token-history-contract/package.jsonpackages/wallet-lib/package.jsonpackages/wallet-utils-contract/package.jsonpackages/wasm-dpp/package.jsonpackages/wasm-dpp2/package.jsonpackages/wasm-drive-verify/package.jsonpackages/wasm-sdk/package.jsonpackages/withdrawals-contract/package.json
| @@ -1,3 +1,30 @@ | |||
| ## [4.0.0-beta.1](///compare/v3.1.0-dev.8...v4.0.0-beta.1) (2026-06-02) | |||
There was a problem hiding this comment.
Fix the malformed release compare URL.
The compare link is currently ///compare/..., which resolves incorrectly and breaks changelog navigation. Use the full repository compare URL format used by the other entries.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` at line 1, The changelog entry header contains a malformed
compare URL "## [4.0.0-beta.1](///compare/v3.1.0-dev.8...v4.0.0-beta.1)
(2026-06-02)"; replace the leading "///compare/..." with the full repository
compare URL used by other entries (e.g.
"https://github.com/<org>/<repo>/compare/v3.1.0-dev.8...v4.0.0-beta.1") so the
link resolves correctly while keeping the rest of the header text intact.
| * add register-contract script to rs-scripts ([#3744](undefined/undefined/undefined/issues/3744)) | ||
| * **dashmate:** configure docker build args via config ([#3764](undefined/undefined/undefined/issues/3764)) | ||
| * **drive-abci:** gate shielded-pool seeding behind `shielded_test_data` feature ([#3774](undefined/undefined/undefined/issues/3774)) | ||
| * **drive:** add document history retrieval ([#3725](undefined/undefined/undefined/issues/3725)) | ||
| * **platform:** add GetShieldedNotesCount query for sync progress ([#3769](undefined/undefined/undefined/issues/3769)) | ||
| * seed Orchard shielded pool at genesis with fast, observable sync ([#3732](undefined/undefined/undefined/issues/3732)) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * **dashmate:** prevent orphaned verification container blocking SSL renewal ([#3162](undefined/undefined/undefined/issues/3162)) | ||
| * **dpp:** block pre-programmed distribution changes on token update ([#3461](undefined/undefined/undefined/issues/3461)) | ||
| * **drive:** consolidate historical contract proof verification retry logic ([#3165](undefined/undefined/undefined/issues/3165)) | ||
| * **platform-wallet:** fix spv client deadlocking himself when trying to stop ([#3742](undefined/undefined/undefined/issues/3742)) | ||
| * **platform-wallet:** satisfy accessors clippy lints ([#3596](undefined/undefined/undefined/issues/3596)) | ||
|
|
||
|
|
||
| ### Tests | ||
|
|
||
| * **swift-sdk:** swift-sdk test updated and added to CI ([#3479](undefined/undefined/undefined/issues/3479)) | ||
| * **wasm-sdk:** fix flaky tokenPaymentInfo document balance assertions ([#3771](undefined/undefined/undefined/issues/3771)) | ||
|
|
There was a problem hiding this comment.
Replace undefined/undefined/undefined issue links with valid GitHub issue URLs.
All new issue references in this section are broken due to an unresolved URL base, so readers can’t navigate to the referenced PR/issues.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` around lines 6 - 27, The CHANGELOG.md contains broken issue
links using the placeholder base "undefined/undefined/undefined" (e.g. the
patterns like ([`#3744`](undefined/undefined/undefined/issues/3744))); update each
broken link to point to the correct GitHub URL for this repository (replace the
undefined/undefined/undefined base with the repo's real org/name path or a full
https://github.com/<ORG>/<REPO>/pull/<PR#> or /issues/<#> URL), and ensure every
occurrence (all instances shown: `#3744`, `#3764`, `#3774`, `#3725`, `#3769`, `#3732`,
`#3162`, `#3461`, `#3165`, `#3742`, `#3596`, `#3479`, `#3771`) is fixed consistently so the
markdown links resolve.
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "15a2096a3f0411f5cf3f78e9582d9262d9a691d0d9393b7a749f30d7faf882aa"
)Xcode manual integration:
|
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Release bookkeeping PR bumping the workspace to 4.0.0-beta.1 and regenerating the changelog. Two real release-artifact issues converged across both agents: the newly generated changelog section has broken compare/issue links (regression vs. prior entries), and three published npm packages (dash, @dashevo/wallet-lib, @dashevo/dash-spv) are getting numeric semver downgrades from their previously independent major streams, which has implications for npm publish and consumer resolution.
🟡 2 suggestion(s)
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `CHANGELOG.md`:
- [SUGGESTION] CHANGELOG.md:1-26: New 4.0.0-beta.1 changelog section has broken compare/issue URLs
The newly generated top section was committed with empty template variables: the heading link is `[4.0.0-beta.1](///compare/v3.1.0-dev.8...v4.0.0-beta.1)` (missing host and repo, resolves to a relative path and 404s) and every PR/issue reference points to `undefined/undefined/undefined/issues/NNNN` instead of `https://github.com/dashpay/platform/issues/NNNN`. The immediately following entry at line 28 (`## [3.1.0-dev.8]`) has fully qualified GitHub URLs, so this is a regression in the changelog generator run for this release cut. Since the purpose of this PR is to publish release notes, shipping malformed links makes the entry unusable for readers following individual changes — re-run the generator (or hand-fix) before tagging.
In `packages/wallet-lib/package.json`:
- [SUGGESTION] packages/wallet-lib/package.json:3: Three published npm packages get a numeric semver downgrade in this bump
These three packages are public on npm (not marked `private`) and were previously on independent, higher major streams:
- `dash` (packages/js-dash-sdk): `6.1.0-dev.8` → `4.0.0-beta.1`
- `@dashevo/wallet-lib` (packages/wallet-lib): `10.1.0-dev.8` → `4.0.0-beta.1`
- `@dashevo/dash-spv` (packages/dash-spv): `4.1.0-dev.8` → `4.0.0-beta.1`
For consumers pinned to `dash@^6`, `@dashevo/wallet-lib@^10`, or `@dashevo/dash-spv@^4.1`, `4.0.0-beta.1` is numerically lower and will not be picked up by their resolver; npm will also refuse to set this as `latest` over an existing higher version (must publish with `--tag beta`). If unifying all platform packages under a single 4.0 stream for the beta is the intent (plausible — js-dash-sdk is documented as legacy and js-evo-sdk is the recommended SDK), that's fine, but confirm explicitly with whoever owns these packages on npm so the publish step (and dist-tag handling) is deliberate. If any of these were not meant to follow the unified stream, the version bump script needs to special-case them.
| ## [4.0.0-beta.1](///compare/v3.1.0-dev.8...v4.0.0-beta.1) (2026-06-02) | ||
|
|
||
|
|
||
| ### Features | ||
|
|
||
| * add register-contract script to rs-scripts ([#3744](undefined/undefined/undefined/issues/3744)) | ||
| * **dashmate:** configure docker build args via config ([#3764](undefined/undefined/undefined/issues/3764)) | ||
| * **drive-abci:** gate shielded-pool seeding behind `shielded_test_data` feature ([#3774](undefined/undefined/undefined/issues/3774)) | ||
| * **drive:** add document history retrieval ([#3725](undefined/undefined/undefined/issues/3725)) | ||
| * **platform:** add GetShieldedNotesCount query for sync progress ([#3769](undefined/undefined/undefined/issues/3769)) | ||
| * seed Orchard shielded pool at genesis with fast, observable sync ([#3732](undefined/undefined/undefined/issues/3732)) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * **dashmate:** prevent orphaned verification container blocking SSL renewal ([#3162](undefined/undefined/undefined/issues/3162)) | ||
| * **dpp:** block pre-programmed distribution changes on token update ([#3461](undefined/undefined/undefined/issues/3461)) | ||
| * **drive:** consolidate historical contract proof verification retry logic ([#3165](undefined/undefined/undefined/issues/3165)) | ||
| * **platform-wallet:** fix spv client deadlocking himself when trying to stop ([#3742](undefined/undefined/undefined/issues/3742)) | ||
| * **platform-wallet:** satisfy accessors clippy lints ([#3596](undefined/undefined/undefined/issues/3596)) | ||
|
|
||
|
|
||
| ### Tests | ||
|
|
||
| * **swift-sdk:** swift-sdk test updated and added to CI ([#3479](undefined/undefined/undefined/issues/3479)) | ||
| * **wasm-sdk:** fix flaky tokenPaymentInfo document balance assertions ([#3771](undefined/undefined/undefined/issues/3771)) |
There was a problem hiding this comment.
🟡 Suggestion: New 4.0.0-beta.1 changelog section has broken compare/issue URLs
The newly generated top section was committed with empty template variables: the heading link is [4.0.0-beta.1](///compare/v3.1.0-dev.8...v4.0.0-beta.1) (missing host and repo, resolves to a relative path and 404s) and every PR/issue reference points to undefined/undefined/undefined/issues/NNNN instead of https://github.com/dashpay/platform/issues/NNNN. The immediately following entry at line 28 (## [3.1.0-dev.8]) has fully qualified GitHub URLs, so this is a regression in the changelog generator run for this release cut. Since the purpose of this PR is to publish release notes, shipping malformed links makes the entry unusable for readers following individual changes — re-run the generator (or hand-fix) before tagging.
| ## [4.0.0-beta.1](///compare/v3.1.0-dev.8...v4.0.0-beta.1) (2026-06-02) | |
| ### Features | |
| * add register-contract script to rs-scripts ([#3744](undefined/undefined/undefined/issues/3744)) | |
| * **dashmate:** configure docker build args via config ([#3764](undefined/undefined/undefined/issues/3764)) | |
| * **drive-abci:** gate shielded-pool seeding behind `shielded_test_data` feature ([#3774](undefined/undefined/undefined/issues/3774)) | |
| * **drive:** add document history retrieval ([#3725](undefined/undefined/undefined/issues/3725)) | |
| * **platform:** add GetShieldedNotesCount query for sync progress ([#3769](undefined/undefined/undefined/issues/3769)) | |
| * seed Orchard shielded pool at genesis with fast, observable sync ([#3732](undefined/undefined/undefined/issues/3732)) | |
| ### Bug Fixes | |
| * **dashmate:** prevent orphaned verification container blocking SSL renewal ([#3162](undefined/undefined/undefined/issues/3162)) | |
| * **dpp:** block pre-programmed distribution changes on token update ([#3461](undefined/undefined/undefined/issues/3461)) | |
| * **drive:** consolidate historical contract proof verification retry logic ([#3165](undefined/undefined/undefined/issues/3165)) | |
| * **platform-wallet:** fix spv client deadlocking himself when trying to stop ([#3742](undefined/undefined/undefined/issues/3742)) | |
| * **platform-wallet:** satisfy accessors clippy lints ([#3596](undefined/undefined/undefined/issues/3596)) | |
| ### Tests | |
| * **swift-sdk:** swift-sdk test updated and added to CI ([#3479](undefined/undefined/undefined/issues/3479)) | |
| * **wasm-sdk:** fix flaky tokenPaymentInfo document balance assertions ([#3771](undefined/undefined/undefined/issues/3771)) | |
| ## [4.0.0-beta.1](https://github.com/dashpay/platform/compare/v3.1.0-dev.8...v4.0.0-beta.1) (2026-06-02) | |
| ### Features | |
| * add register-contract script to rs-scripts ([#3744](https://github.com/dashpay/platform/issues/3744)) | |
| * **dashmate:** configure docker build args via config ([#3764](https://github.com/dashpay/platform/issues/3764)) | |
| * **drive-abci:** gate shielded-pool seeding behind `shielded_test_data` feature ([#3774](https://github.com/dashpay/platform/issues/3774)) | |
| * **drive:** add document history retrieval ([#3725](https://github.com/dashpay/platform/issues/3725)) | |
| * **platform:** add GetShieldedNotesCount query for sync progress ([#3769](https://github.com/dashpay/platform/issues/3769)) | |
| * seed Orchard shielded pool at genesis with fast, observable sync ([#3732](https://github.com/dashpay/platform/issues/3732)) | |
| ### Bug Fixes | |
| * **dashmate:** prevent orphaned verification container blocking SSL renewal ([#3162](https://github.com/dashpay/platform/issues/3162)) | |
| * **dpp:** block pre-programmed distribution changes on token update ([#3461](https://github.com/dashpay/platform/issues/3461)) | |
| * **drive:** consolidate historical contract proof verification retry logic ([#3165](https://github.com/dashpay/platform/issues/3165)) | |
| * **platform-wallet:** fix spv client deadlocking himself when trying to stop ([#3742](https://github.com/dashpay/platform/issues/3742)) | |
| * **platform-wallet:** satisfy accessors clippy lints ([#3596](https://github.com/dashpay/platform/issues/3596)) | |
| ### Tests | |
| * **swift-sdk:** swift-sdk test updated and added to CI ([#3479](https://github.com/dashpay/platform/issues/3479)) | |
| * **wasm-sdk:** fix flaky tokenPaymentInfo document balance assertions ([#3771](https://github.com/dashpay/platform/issues/3771)) |
source: ['claude', 'codex']
| { | ||
| "name": "@dashevo/wallet-lib", | ||
| "version": "10.1.0-dev.8", | ||
| "version": "4.0.0-beta.1", |
There was a problem hiding this comment.
🟡 Suggestion: Three published npm packages get a numeric semver downgrade in this bump
These three packages are public on npm (not marked private) and were previously on independent, higher major streams:
dash(packages/js-dash-sdk):6.1.0-dev.8→4.0.0-beta.1@dashevo/wallet-lib(packages/wallet-lib):10.1.0-dev.8→4.0.0-beta.1@dashevo/dash-spv(packages/dash-spv):4.1.0-dev.8→4.0.0-beta.1
For consumers pinned to dash@^6, @dashevo/wallet-lib@^10, or @dashevo/dash-spv@^4.1, 4.0.0-beta.1 is numerically lower and will not be picked up by their resolver; npm will also refuse to set this as latest over an existing higher version (must publish with --tag beta). If unifying all platform packages under a single 4.0 stream for the beta is the intent (plausible — js-dash-sdk is documented as legacy and js-evo-sdk is the recommended SDK), that's fine, but confirm explicitly with whoever owns these packages on npm so the publish step (and dist-tag handling) is deliberate. If any of these were not meant to follow the unified stream, the version bump script needs to special-case them.
source: ['claude', 'codex']
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Cumulative re-review at 3573f4ed after the new push from 35e4ce32.
The latest delta fixes one prior finding and leaves one prior finding still valid:
🟡 1 suggestion(s) carried forward (existing inline thread already open)
Incremental reconciliation
- STILL VALID:
CHANGELOG.md:1-26— the new4.0.0-beta.1changelog section still ships broken generated URLs: the compare link is///compare/v3.1.0-dev.8...v4.0.0-beta.1, and PR references still point atundefined/undefined/undefined/issues/NNNN. I’m not opening a duplicate inline thread because the same finding is already open on this PR, but it still applies at this head. - FIXED: the npm semver downgrade concern is fixed in the latest delta:
dashis now7.0.0-beta.1,@dashevo/wallet-libis11.0.0-beta.1, and@dashevo/dash-spvis5.0.0-beta.1. - New findings in latest delta: none.
2 participants
Issue being fixed or feature implemented
Release new Dash Platform version
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit