Draft
Conversation
…exceptions Invert the deploy/destroy approval logic: instead of listing specific resource types to warn about (schemas, volumes, pipelines, dashboards), warn for all resource types by default and maintain an allowlist of resources that are safe to delete/recreate without data loss. Resources now safe-listed (no warning): jobs, model_serving_endpoints, clusters, apps, sql_warehouses, external_locations, synced_database_tables, postgres_endpoints. All other resources (15 types) now trigger a warning, including newly warned: catalogs, secret_scopes, database_instances, database_catalogs, postgres_projects, postgres_branches, models, registered_models, experiments, quality_monitors, alerts. Co-authored-by: Isaac
Child resources like permissions and grants (e.g. "apps.permissions") were not recognized as belonging to a safe parent resource type, causing an empty warning header to appear during destroy. Co-authored-by: Isaac
… filter Move the IsChildResource() check from the printing loop into the collection loop. Deleting permissions or grants of a resource does not cause data loss, so they should not trigger the warning prompt regardless of the parent resource type. Co-authored-by: Isaac
## Summary - Pin all GitHub action references to their commit SHAs - Each SHA maps to the current tag for the action at the time of pinning
Replace the generic "data loss" message with informative per-resource-type messages. A new resourceDestroyMessage map maps each resource type to its specific warning (or empty string for safe types). This map serves as the single source of truth for both the warning text and the safe/unsafe decision. Add TestResourceDestroyMessageIsComplete to ensure every resource type in SupportedResources() has an entry in the map, and vice versa. Co-authored-by: Isaac
Collaborator
|
Commit: c851fa5
39 interesting tests: 12 BUG, 10 FAIL, 9 SKIP, 8 KNOWN
Top 21 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Tests