Add relative path translation for alert_task.workspace_path in job tasks#4836
Open
shreyas-goenka wants to merge 1 commit intomainfrom
Open
Add relative path translation for alert_task.workspace_path in job tasks#4836shreyas-goenka wants to merge 1 commit intomainfrom
shreyas-goenka wants to merge 1 commit intomainfrom
Conversation
shreyas-goenka
force-pushed
the
alert-task-workspace-path
branch
from
7bcabc7 to
39fc774
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 825581a
17 interesting tests: 10 SKIP, 7 RECOVERED
Top 29 slowest tests (at least 2 minutes):
|
shreyas-goenka
force-pushed
the
alert-task-workspace-path
branch
from
39fc774 to
3f84960
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
…tasks Co-authored-by: Isaac
shreyas-goenka
commented
Mar 26, 2026
| RecordRequests = false | ||
| Ignore = ["databricks.yml", ".databricks"] | ||
|
|
||
| [EnvMatrix] |
Contributor
Author
There was a problem hiding this comment.
the current TF version does not support this yet.
shreyas-goenka
force-pushed
the
alert-task-workspace-path
branch
from
3f84960 to
825581a
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik,
pietern and
simonfaltum
as code owners
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: medium Eligible reviewersBased on CODEOWNERS, these people or teams could also review: @anton-107, @denik, @pietern, @simonfaltum Suggestions based on git history of 9 changed files (3 scored). See CODEOWNERS for path-specific ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alert_task.workspace_pathto the job task path rewrite patterns so relative paths (e.g../my_alert.dbalert.json) are translated to full workspace pathsfor_each_tasknested tasks viaTranslateModeFileTest plan
TestVisitJobPaths,TestVisitJobPaths_foreach)TestTranslatePathsInSubdirectories)acceptance/bundle/resources/jobs/alert-task) — deploys a job withalert_task.workspace_path, reads it back viajobs get, and asserts the fully qualified workspace path. Runs on both local (mock server) and cloud (direct engine only; terraform provider doesn't supportalert_taskyet).This pull request was AI-assisted by Isaac.