Replace JSON schema validation in CI with Go test by shreyas-goenka · Pull Request #4848 · databricks/cli

shreyas-goenka · 2026-03-26T14:11:31Z

Summary

Remove the ajv-cli npm dependency from CI workflow
Add a Go unit test (bundle/schema/validate_test.go) using google/jsonschema-go that validates the generated bundle schema against the existing pass/fail test data files
The nested $defs structure (mirroring Go import paths) is flattened into flat keys with $ref values rewritten to use JSON Pointer ~1 escaping, for compatibility with the Google library

Test plan

go test ./bundle/schema/ -v passes all tests (12 pass cases, 14 fail cases)

This pull request was AI-assisted by Isaac.

Remove the ajv-cli npm dependency from CI and replace it with a Go test using santhosh-tekuri/jsonschema/v6. This validates the generated bundle schema against pass/fail test cases entirely in Go. Co-authored-by: Isaac

Transform the nested $defs structure (which mirrors Go import paths) into flat keys before passing to the Google library, and rewrite $ref values to use JSON Pointer ~1 escaping for the flattened keys. Co-authored-by: Isaac

Co-authored-by: Isaac

eng-dev-ecosystem-bot · 2026-03-26T14:43:27Z

Commit: f79d99f

Run: 23641709190

	Env	🟨KNOWN	💚RECOVERED	🙈SKIP	✅pass	🙈skip	Time
🟨	aws linux	7		10	270	807	7:17
🟨	aws windows	7		10	272	805	6:09
💚	aws-ucws linux		7	10	366	723	8:55
💚	aws-ucws windows		7	10	368	721	6:22
💚	azure linux		1	12	273	805	6:45
💚	azure windows		1	12	275	803	5:01
💚	azure-ucws linux		1	12	371	719	7:35
💚	azure-ucws windows		1	12	373	717	6:18
💚	gcp linux		1	12	269	808	6:29
💚	gcp windows		1	12	271	806	5:06

17 interesting tests: 10 SKIP, 7 KNOWN

	Test Name	aws linux	aws windows	aws-ucws linux	aws-ucws windows	azure linux	azure windows	azure-ucws linux	azure-ucws windows	gcp linux	gcp windows
🟨	TestAccept	🟨K	🟨K	💚R	💚R	💚R	💚R	💚R	💚R	💚R	💚R
🙈	TestAccept/bundle/resources/permissions	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions	🟨K	🟨K	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct	🟨K	🟨K	💚R	💚R
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	🟨K	🟨K	💚R	💚R
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions	🟨K	🟨K	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct	🟨K	🟨K	💚R	💚R
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	🟨K	🟨K	💚R	💚R
🙈	TestAccept/bundle/resources/postgres_branches/basic	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/postgres_branches/recreate	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/postgres_branches/update_protected	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/postgres_branches/without_branch_id	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/postgres_endpoints/basic	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/postgres_endpoints/recreate	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/postgres_projects/update_display_name	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/synced_database_tables/basic	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/ssh/connection	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S

Top 24 slowest tests (at least 2 minutes):

duration	env	testname
3:45	gcp windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:42	gcp linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:18	aws-ucws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:15	azure linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:15	gcp linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:14	azure-ucws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:13	aws-ucws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:13	aws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:11	aws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:07	gcp windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:48	aws-ucws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:45	azure-ucws linux	TestAccept
2:44	aws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:43	azure linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:43	azure windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:42	aws-ucws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:38	aws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:36	aws-ucws linux	TestAccept
2:36	azure windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:29	gcp linux	TestAccept
2:26	azure linux	TestAccept
2:17	azure-ucws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:13	azure-ucws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:11	azure-ucws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform

Co-authored-by: Isaac

Check value types instead of matching against a keyword list. Intermediate nesting nodes only have map[string]any values, while schema definitions always have at least one non-object value (string, array, bool, etc.). Co-authored-by: Isaac

Co-authored-by: Isaac

$defs keys are Go package paths and never contain ~. Co-authored-by: Isaac

Use a table mapping each fail test file to the expected schema location in the error. Also fail if a new test file is added without a table entry. Co-authored-by: Isaac

Co-authored-by: Isaac

Use a table mapping each fail test file to the expected schema location in the error. Also fail if a new test file is added without a table entry. Co-authored-by: Isaac

Co-authored-by: Isaac

github-actions · 2026-03-26T18:04:23Z

Suggested reviewers

Based on git history of the changed files, these people are best suited to review:

@simonfaltum -- recent work in ./
@pietern -- recent work in .github/workflows/, ./

Confidence: medium

Eligible reviewers

Based on CODEOWNERS, these people or teams could also review:

@andrewnester, @anton-107, @denik

_{Suggestions based on git history of 4 changed files (3 scored). See CODEOWNERS for path-specific ownership rules.}

bundle/schema/validate_test.go

go.mod

bundle/schema/validate_test.go

go.mod

Move google/jsonschema-go require into main deps section, add NOTICE entry under MIT section, and document why fail tests only assert on schema path (oneOf wrapping discards branch-specific errors). Co-authored-by: Isaac

eng-dev-ecosystem-bot · 2026-03-27T14:02:21Z

Commit: e5c1351

Run: 23645842382

	Env	❌FAIL	🟨KNOWN	🔄flaky	💚RECOVERED	🙈SKIP	✅pass	🙈skip	Time
🟨	aws linux		7	2		10	498	761	50:02
🟨	aws windows		7			10	472	769	51:33
❌	aws-ucws linux	3	3	6	21	2	795	605	95:35
❌	aws-ucws windows	3	3	2	23	2	760	616	76:52
🔄	azure linux			7	1	12	496	759	59:29
🔄	azure windows			4	1	12	471	767	69:17
❌	azure-ucws linux	7	1	2	3	11	773	608	95:18
❌	azure-ucws windows	7	1	4	3	11	734	619	95:17
🔄	gcp linux			4	1	12	481	767	67:48
🔄	gcp windows			6	1	12	451	775	87:33

59 interesting tests: 26 flaky, 15 RECOVERED, 9 KNOWN, 7 FAIL, 2 SKIP

	Test Name	aws linux	aws windows	aws-ucws linux	aws-ucws windows	azure linux	azure windows	azure-ucws linux	azure-ucws windows	gcp linux	gcp windows
🟨	TestAccept	🟨K	🟨K	🟨K	🟨K	💚R	💚R	🟨K	🟨K	💚R	💚R
🔄	TestAccept/bundle/integration_whl/interactive_cluster	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f
🔄	TestAccept/bundle/integration_whl/interactive_cluster/DATABRICKS_BUNDLE_ENGINE=direct	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f
🔄	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version	✅p	✅p	✅p	✅p	✅p	🔄f	🔄f	🔄f	🔄f	🔄f
🔄	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=direct/DATA_SECURITY_MODE=SINGLE_USER	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p
🔄	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	🔄f
🔄	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=USER_ISOLATION	✅p	✅p	✅p	✅p	✅p	🔄f	🔄f	✅p	✅p	✅p
🔄	TestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=direct	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p
🔄	TestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p
🔄	TestAccept/bundle/resources/clusters/run/spark_python_task	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p
🔄	TestAccept/bundle/resources/clusters/run/spark_python_task/DATABRICKS_BUNDLE_ENGINE=direct	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f
🔄	TestAccept/bundle/resources/clusters/run/spark_python_task/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	🔄f
❌	TestAccept/bundle/resources/grants/schemas/duplicate_principals	🙈s	🙈s	✅p	✅p	🙈s	🙈s	❌F	❌F	🙈s	🙈s
❌	TestAccept/bundle/resources/grants/schemas/duplicate_principals/DATABRICKS_BUNDLE_ENGINE=direct			✅p	✅p			❌F	❌F
❌	TestAccept/bundle/resources/grants/schemas/out_of_band_principal	🙈s	🙈s	✅p	✅p	🙈s	🙈s	❌F	❌F	🙈s	🙈s
❌	TestAccept/bundle/resources/grants/schemas/out_of_band_principal/DATABRICKS_BUNDLE_ENGINE=direct			✅p	✅p			❌F	❌F
❌	TestAccept/bundle/resources/grants/schemas/remove_principal	🙈s	🙈s	❌F	❌F	🙈s	🙈s	❌F	❌F	🙈s	🙈s
❌	TestAccept/bundle/resources/grants/schemas/remove_principal/DATABRICKS_BUNDLE_ENGINE=direct			❌F	❌F			❌F	❌F
❌	TestAccept/bundle/resources/grants/schemas/remove_principal/DATABRICKS_BUNDLE_ENGINE=terraform			❌F	❌F			❌F	❌F
🙈	TestAccept/bundle/resources/permissions	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🔄	TestAccept/bundle/resources/permissions/factcheck	✅p	✅p	✅p	✅p	🔄f	🔄f	✅p	✅p	🙈s	🙈s
🔄	TestAccept/bundle/resources/permissions/factcheck/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	✅p	🔄f	🔄f	✅p	✅p
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions	🟨K	🟨K	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct	🟨K	🟨K	💚R	💚R
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	🟨K	🟨K	💚R	💚R
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions	🟨K	🟨K	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct	🟨K	🟨K	💚R	💚R
🟨	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	🟨K	🟨K	💚R	💚R
🔄	TestAccept/bundle/resources/postgres_branches/basic	🙈S	🙈S	🔄f	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🔄	TestAccept/bundle/resources/postgres_branches/basic/DATABRICKS_BUNDLE_ENGINE=direct			🔄f	💚R
💚	TestAccept/bundle/resources/postgres_branches/basic/DATABRICKS_BUNDLE_ENGINE=terraform			💚R	💚R
🔄	TestAccept/bundle/resources/postgres_branches/recreate	🙈S	🙈S	🔄f	🔄f	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🔄	TestAccept/bundle/resources/postgres_branches/recreate/DATABRICKS_BUNDLE_ENGINE=direct			🔄f	🔄f
💚	TestAccept/bundle/resources/postgres_branches/recreate/DATABRICKS_BUNDLE_ENGINE=terraform			💚R	💚R
💚	TestAccept/bundle/resources/postgres_branches/update_protected	🙈S	🙈S	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/resources/postgres_branches/update_protected/DATABRICKS_BUNDLE_ENGINE=direct			💚R	💚R
💚	TestAccept/bundle/resources/postgres_branches/update_protected/DATABRICKS_BUNDLE_ENGINE=terraform			💚R	💚R
💚	TestAccept/bundle/resources/postgres_branches/without_branch_id	🙈S	🙈S	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/resources/postgres_branches/without_branch_id/DATABRICKS_BUNDLE_ENGINE=direct			💚R	💚R
💚	TestAccept/bundle/resources/postgres_branches/without_branch_id/DATABRICKS_BUNDLE_ENGINE=terraform			💚R	💚R
💚	TestAccept/bundle/resources/postgres_endpoints/basic	🙈S	🙈S	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/resources/postgres_endpoints/basic/DATABRICKS_BUNDLE_ENGINE=terraform			💚R	💚R
💚	TestAccept/bundle/resources/postgres_endpoints/recreate	🙈S	🙈S	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/resources/postgres_endpoints/recreate/DATABRICKS_BUNDLE_ENGINE=direct			💚R	💚R
🟨	TestAccept/bundle/resources/postgres_projects/update_display_name	🙈S	🙈S	🟨K	🟨K	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🟨	TestAccept/bundle/resources/postgres_projects/update_display_name/DATABRICKS_BUNDLE_ENGINE=terraform			🟨K	🟨K
💚	TestAccept/bundle/resources/synced_database_tables/basic	🙈S	🙈S	💚R	💚R	🙈S	🙈S	💚R	💚R	🙈S	🙈S
💚	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=direct			💚R	💚R			💚R	💚R
💚	TestAccept/bundle/resources/synced_database_tables/basic/DATABRICKS_BUNDLE_ENGINE=terraform			💚R	💚R			💚R	💚R
🔄	TestAccept/bundle/templates/default-python/combinations/classic	🔄f	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=yes/NBOOK=no/PY=no/READPLAN=	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct/DLT=yes/NBOOK=no/PY=no/READPLAN=1	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=terraform/DLT=no/NBOOK=no/PY=yes/READPLAN=	🔄f	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=terraform/DLT=yes/NBOOK=yes/PY=no/READPLAN=	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/integration_classic	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
🔄	TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=terraform/UV_PYTHON=3.12	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p	✅p	✅p
🙈	TestAccept/ssh/connection	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🔄	TestSparkJarTaskDeployAndRunOnVolumes/Databricks_Runtime_13.3_LTS	🙈s	🙈s	🔄f	✅p	🙈s	🙈s	✅p	✅p	🙈s	🙈s
🔄	TestSparkJarTaskDeployAndRunOnVolumes/Databricks_Runtime_14.3_LTS	🙈s	🙈s	🔄f	✅p	🙈s	🙈s	✅p	✅p	🙈s	🙈s

Top 50 slowest tests (at least 2 minutes):

duration	env	testname
20:25	azure-ucws windows	TestAccept/bundle/resources/permissions/factcheck/DATABRICKS_BUNDLE_ENGINE=terraform
16:15	aws-ucws windows	TestAccept/bundle/integration_whl/custom_params/DATABRICKS_BUNDLE_ENGINE=terraform
15:48	aws-ucws windows	TestSparkJarTaskDeployAndRunOnVolumes/Databricks_Runtime_15.4_LTS
14:29	gcp windows	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER
13:45	gcp linux	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER
13:38	aws-ucws linux	TestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=terraform
13:04	aws-ucws linux	TestSparkJarTaskDeployAndRunOnVolumes/Databricks_Runtime_15.4_LTS
12:52	gcp windows	TestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform
12:41	azure-ucws linux	TestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform
12:13	aws windows	TestAccept/bundle/integration_whl/custom_params/DATABRICKS_BUNDLE_ENGINE=terraform
12:04	aws-ucws windows	TestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=terraform
11:59	gcp linux	TestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform
11:47	aws-ucws windows	TestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform
11:39	aws-ucws windows	TestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=direct
11:18	azure windows	TestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform
11:14	aws-ucws linux	TestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=direct
10:46	azure linux	TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
10:22	azure-ucws windows	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=USER_ISOLATION
10:21	azure-ucws windows	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER
10:00	azure windows	TestAccept/bundle/resources/permissions/factcheck/DATABRICKS_BUNDLE_ENGINE=terraform
9:37	azure-ucws linux	TestAccept/bundle/integration_whl/interactive_cluster/DATABRICKS_BUNDLE_ENGINE=terraform
9:37	aws linux	TestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform
9:27	azure windows	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=direct/DATA_SECURITY_MODE=USER_ISOLATION
9:25	aws-ucws linux	TestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform
9:15	aws windows	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER
9:14	azure-ucws linux	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=direct/DATA_SECURITY_MODE=SINGLE_USER
9:13	gcp linux	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=USER_ISOLATION
9:13	aws-ucws windows	TestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=direct
9:13	aws linux	TestAccept/bundle/integration_whl/wrapper/DATABRICKS_BUNDLE_ENGINE=terraform
9:01	azure-ucws windows	TestAccept/bundle/run/app-with-job/DATABRICKS_BUNDLE_ENGINE=terraform
8:57	aws-ucws windows	TestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform
8:55	azure windows	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER
8:41	azure-ucws linux	TestAccept/bundle/resources/permissions/factcheck/DATABRICKS_BUNDLE_ENGINE=terraform
8:37	aws windows	TestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=direct
8:31	azure-ucws windows	TestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform
8:23	gcp windows	TestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform
8:23	gcp linux	TestAccept/bundle/integration_whl/interactive_cluster/DATABRICKS_BUNDLE_ENGINE=direct
8:18	gcp linux	TestAccept/bundle/resources/clusters/run/spark_python_task/DATABRICKS_BUNDLE_ENGINE=direct
8:11	azure windows	TestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=direct
8:00	azure-ucws linux	TestAccept/bundle/run/app-with-job/DATABRICKS_BUNDLE_ENGINE=terraform
8:00	azure windows	TestAccept/bundle/resources/clusters/run/spark_python_task/DATABRICKS_BUNDLE_ENGINE=terraform
7:56	aws linux	TestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=direct
7:54	gcp linux	TestAccept/bundle/run/app-with-job/DATABRICKS_BUNDLE_ENGINE=direct
7:53	gcp windows	TestAccept/bundle/integration_whl/interactive_cluster/DATABRICKS_BUNDLE_ENGINE=direct
7:40	aws-ucws linux	TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=USER_ISOLATION
7:39	gcp windows	TestAccept/bundle/run/app-with-job/DATABRICKS_BUNDLE_ENGINE=terraform
7:38	gcp windows	TestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=direct
7:37	gcp linux	TestAccept/bundle/run/app-with-job/DATABRICKS_BUNDLE_ENGINE=terraform
7:32	gcp windows	TestAccept/bundle/integration_whl/interactive_cluster/DATABRICKS_BUNDLE_ENGINE=terraform
7:29	gcp linux	TestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform

Replace ajv npm-based JSON schema validation with Go unit test

b05d280

Remove the ajv-cli npm dependency from CI and replace it with a Go test using santhosh-tekuri/jsonschema/v6. This validates the generated bundle schema against pass/fail test cases entirely in Go. Co-authored-by: Isaac

shreyas-goenka temporarily deployed to test-trigger-is March 26, 2026 14:12 — with GitHub Actions Inactive

Use google/jsonschema-go instead of santhosh-tekuri/jsonschema

19ddf22

Transform the nested $defs structure (which mirrors Go import paths) into flat keys before passing to the Google library, and rewrite $ref values to use JSON Pointer ~1 escaping for the flattened keys. Co-authored-by: Isaac

shreyas-goenka temporarily deployed to test-trigger-is March 26, 2026 14:21 — with GitHub Actions Inactive

Fix lint: remove loop var copy, fix formatting, use slice for keywords

20663a7

Co-authored-by: Isaac

shreyas-goenka temporarily deployed to test-trigger-is March 26, 2026 14:31 — with GitHub Actions Inactive

Remove extra blank line in push.yml

c202fa6

Co-authored-by: Isaac

shreyas-goenka temporarily deployed to test-trigger-is March 26, 2026 14:48 — with GitHub Actions Inactive

shreyas-goenka temporarily deployed to test-trigger-is March 26, 2026 14:52 — with GitHub Actions Inactive

Clarify rewriteRefs comment

fd8611a

Co-authored-by: Isaac

shreyas-goenka temporarily deployed to test-trigger-is March 26, 2026 15:18 — with GitHub Actions Inactive

Remove unnecessary ~0 escaping in rewriteRef

5c15b4e

$defs keys are Go package paths and never contain ~. Co-authored-by: Isaac

shreyas-goenka temporarily deployed to test-trigger-is March 26, 2026 15:20 — with GitHub Actions Inactive

Assert expected error substrings in fail test cases

7a331d3

Use a table mapping each fail test file to the expected schema location in the error. Also fail if a new test file is added without a table entry. Co-authored-by: Isaac

shreyas-goenka temporarily deployed to test-trigger-is March 26, 2026 15:28 — with GitHub Actions Inactive

Add MIT license comment for google/jsonschema-go in go.mod

09b1914

Co-authored-by: Isaac

shreyas-goenka temporarily deployed to test-trigger-is March 26, 2026 15:30 — with GitHub Actions Inactive

Assert expected error substrings in fail test cases

5aba499

Use a table mapping each fail test file to the expected schema location in the error. Also fail if a new test file is added without a table entry. Co-authored-by: Isaac

shreyas-goenka temporarily deployed to test-trigger-is March 26, 2026 16:53 — with GitHub Actions Inactive

Simplify fail test assertions to single expected path string

4779979

Co-authored-by: Isaac

shreyas-goenka temporarily deployed to test-trigger-is March 26, 2026 18:01 — with GitHub Actions Inactive

shreyas-goenka marked this pull request as ready for review March 26, 2026 18:03

shreyas-goenka requested review from andrewnester, anton-107, denik, pietern and simonfaltum as code owners March 26, 2026 18:03

shreyas-goenka commented Mar 26, 2026

View reviewed changes

bundle/schema/validate_test.go Show resolved Hide resolved

pietern reviewed Mar 27, 2026

View reviewed changes

go.mod Outdated Show resolved Hide resolved

bundle/schema/validate_test.go Show resolved Hide resolved

pietern changed the title ~~Replace ajv npm-based JSON schema validation with Go unit test~~ Replace JSON schema validation in CI with Go unit test Mar 27, 2026

pietern changed the title ~~Replace JSON schema validation in CI with Go unit test~~ Replace JSON schema validation in CI with Go test Mar 27, 2026

pietern approved these changes Mar 27, 2026

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Address PR review: inline dep, add NOTICE, add oneOf comment

f79d99f

Move google/jsonschema-go require into main deps section, add NOTICE entry under MIT section, and document why fail tests only assert on schema path (oneOf wrapping discards branch-specific errors). Co-authored-by: Isaac

shreyas-goenka temporarily deployed to test-trigger-is March 27, 2026 10:21 — with GitHub Actions Inactive

shreyas-goenka added this pull request to the merge queue Mar 27, 2026

Merged via the queue into main with commit e5c1351 Mar 27, 2026
24 checks passed

shreyas-goenka deleted the jsonschema-npm-cleanup branch March 27, 2026 12:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace JSON schema validation in CI with Go test#4848

Replace JSON schema validation in CI with Go test#4848
shreyas-goenka merged 12 commits intomainfrom
jsonschema-npm-cleanup

shreyas-goenka commented Mar 26, 2026 •

edited

Loading

Uh oh!

eng-dev-ecosystem-bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eng-dev-ecosystem-bot commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

shreyas-goenka commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

eng-dev-ecosystem-bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 26, 2026

Suggested reviewers

Eligible reviewers

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eng-dev-ecosystem-bot commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shreyas-goenka commented Mar 26, 2026 •

edited

Loading

eng-dev-ecosystem-bot commented Mar 26, 2026 •

edited

Loading