Extend implicit dependency detection to all UC resources#4854
Open
shreyas-goenka wants to merge 9 commits intomainfrom
Open
Extend implicit dependency detection to all UC resources#4854shreyas-goenka wants to merge 9 commits intomainfrom
shreyas-goenka wants to merge 9 commits intomainfrom
Conversation
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 2988339
17 interesting tests: 10 SKIP, 7 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
changed the title
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
force-pushed
the
fix-implicit-dependency-check
branch
from
31bdd4b to
fe0119c
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik,
pietern and
simonfaltum
as code owners
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: high Eligible reviewersBased on CODEOWNERS, these people or teams could also review: @andrewnester, @anton-107, @pietern, @simonfaltum Suggestions based on git history of 26 changed files (4 scored). See CODEOWNERS for path-specific ownership rules. |
…catalogs The CaptureSchemaDependency mutator now captures implicit dependencies for: - Registered models: both schema_name and catalog_name are resolved - Volumes: catalog_name is now also resolved (schema_name was already handled) Also fixes an ordering bug where resolveSchema modified schema.CatalogName before volumes/pipelines could use it for findSchema lookups. Schemas are now resolved last in Apply(). Co-authored-by: Isaac
…ing endpoints Extends CaptureSchemaDependency to also resolve: - Quality monitors: OutputSchemaName (compound "catalog.schema" format) - Model serving endpoints: AiGateway.InferenceTableConfig and Config.AutoCaptureConfig catalog/schema references Co-authored-by: Isaac
The old name was too narrow — the mutator now resolves both schema and catalog references across all UC resource types, not just schema dependencies. Co-authored-by: Isaac
Co-authored-by: Isaac
- Extract resolveSchema() and resolveCatalog() helpers that return the resolved value (or the original if no match), eliminating duplicated find-then-set logic across every resource type. - Inline nil checks and field assignments directly in Apply() instead of separate per-resource functions, reducing indirection. - Group findSchema/findCatalog together with resolveSchema/resolveCatalog for better locality. Co-authored-by: Isaac
Pipelines have a Catalog field that was used to look up schemas but was
never itself resolved to an explicit ${resources.catalogs.<key>.name}
reference.
Co-authored-by: Isaac
…nce tests Co-authored-by: Isaac
shreyas-goenka
force-pushed
the
fix-implicit-dependency-check
branch
from
b41583e to
90ec9c5
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Co-authored-by: Isaac
shreyas-goenka
force-pushed
the
fix-implicit-dependency-check
branch
from
90ec9c5 to
4ad29e3
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
The CaptureUCDependencies mutator correctly resolves volume catalog and schema references, fixing the previously tracked Badness. Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schema_nameandcatalog_nameresolved to${resources.schemas/catalogs.<key>.name})output_schema_namecompound field resolved)ai_gateway.inference_table_configandconfig.auto_capture_config)CaptureSchemaDependency.Apply(): schemas are now resolved last so thatfindSchemacan still match against originalschema.CatalogNamevalues beforeresolveSchemamutates themTest plan
implicit_deps_volume,implicit_deps_registered_model,implicit_deps_quality_monitor,implicit_deps_model_serving_endpoint) passing with both terraform and direct engines