Add telemetry for escape patterns in bundle configs#4863
Open
shreyas-goenka wants to merge 2 commits intomainfrom
Open
Add telemetry for escape patterns in bundle configs#4863shreyas-goenka wants to merge 2 commits intomainfrom
shreyas-goenka wants to merge 2 commits intomainfrom
Conversation
Collect boolean metrics on whether users have double-dollar or backslash-dollar escape patterns in their config values. This data will inform whether we need escape sequence support in the interpolation parser. Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Four boolean metrics now:
- config_has_double_dollar_brace ($${)
- config_has_double_dollar ($$ not followed by {)
- config_has_backslash_dollar_brace (\${)
- config_has_backslash_dollar (\$ not followed by {)
Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik,
pietern and
simonfaltum
as code owners
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: low Eligible reviewersBased on CODEOWNERS, these people or teams could also review: @andrewnester, @anton-107, @pietern, @simonfaltum Suggestions based on git history of 3 changed files (1 scored). See CODEOWNERS for path-specific ownership rules. |
Collaborator
|
Commit: cd28565
17 interesting tests: 10 SKIP, 7 KNOWN
Top 21 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config_has_double_dollar_brace—$${config_has_double_dollar—$$not followed by{config_has_backslash_dollar_brace—\${config_has_backslash_dollar—\$not followed by{Test plan
This pull request was AI-assisted by Isaac.