Migrate manual files to logging abstraction#742
Draft
mihaimitrea-db wants to merge 3 commits intomainfrom
Draft
Conversation
This was referenced Mar 26, 2026
09f9d8b to
e07eca3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Summary
Migrates all manually-maintained source files from direct
org.slf4jimports to the SDK's logging abstraction (com.databricks.sdk.core.logging). After this PR, no hand-written file in the SDK referencesSLF4J directly — all logging goes through the abstraction introduced in PR #740.
Why
PRs #740 and #741 introduced the logging abstraction and the JUL backend, but every existing call site still imported
org.slf4j.Loggerandorg.slf4j.LoggerFactorydirectly. Until those imports arerewritten, users cannot actually swap the logging backend — the abstraction would be dead code.
This PR completes the migration for all manually-maintained files. Auto-generated files are left unchanged and will be addressed separately via codegen updates.
What changed
Interface changes
None.
Behavioral changes
None. All logging calls pass through the abstraction layer, which defaults to SLF4J. Existing users see no difference.
Internal changes
org.slf4j.Logger/org.slf4j.LoggerFactoryimports are replaced withcom.databricks.sdk.core.logging.Logger/com.databricks.sdk.core.logging.LoggerFactory. Noother code changes — the
LoggerAPI is identical.core,core.oauth,core.retry,core.utils,core.error,core.commons, andmixinpackages.How is this tested?
Loggerabstraction exposes the samedebug/info/warn/errormethods asorg.slf4j.Logger.