feat(redshift_grant): add role read support#33
Open
Intuinewin wants to merge 6 commits intodbsystel:masterfrom
Open
feat(redshift_grant): add role read support#33Intuinewin wants to merge 6 commits intodbsystel:masterfrom
Intuinewin wants to merge 6 commits intodbsystel:masterfrom
Conversation
Intuinewin
changed the title
Intuinewin
force-pushed
the
roles-implem-read
branch
from
5325f0f to
9ee0794
Compare
mmichaelb
reviewed
Mar 11, 2026
mmichaelb
reviewed
Mar 11, 2026
redshift/resource_redshift_grant.go
Outdated
| ns.nspname=$1 | ||
| AND gr.groname=$2 | ||
| ` | ||
| } else { |
There was a problem hiding this comment.
mmichaelb
reviewed
Mar 11, 2026
mmichaelb
reviewed
Mar 11, 2026
mmichaelb
reviewed
Mar 11, 2026
mmichaelb
requested changes
Mar 11, 2026
|
First of all, I would like to apologize for taking so long to review this. Apart from the minor changes, the pull request looks very good to me. Thank you very much for the extension, it really helps this provider move forward! I will regression test the feature and then release it afterwards. Considering the breaking change: Due to this provider still not being released with a stable major version number, I will release a new minor version including this breaking change and add a note including migration tasks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cc @mmichaelb
Following of #13
Reading grants with role works with the svv views, maybe all the other queries should be refacto to use these views? (parsing acl is no loger needed)
Also: possibly a breaking change (a3ce051) because the first PR wasn't generating ids with role name