feat(redshift_default_privileges): add role support#34
Open
Intuinewin wants to merge 1 commit intodbsystel:masterfrom
Open
feat(redshift_default_privileges): add role support#34Intuinewin wants to merge 1 commit intodbsystel:masterfrom
Intuinewin wants to merge 1 commit intodbsystel:masterfrom
Conversation
e6037ea to
8e63dbb
Compare
|
Hi @mmichaelb, do you have any news about this PR ? |
|
Thank you for your contribution! I am currently reviewing this and coming across the previous /cc @nico34638 |
|
The changes look good to me so far. In the next days, I will do some regression tests and after completing these tests, this feature can be merged. Due to the changes only adding a further option instead of changes an existing one, I would consider this a non breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds role support to the resource
redshift_default_privileges. It also updates the code to use the tablesvv_default_privilegeswhich contains the default privleges instead of thepg_default_acltableDocs: https://docs.aws.amazon.com/redshift/latest/dg/r_SVV_DEFAULT_PRIVILEGES.html