[dmt] fix YAML document splitting for block scalars#362
Open
diyliv wants to merge 2 commits into
Open
Conversation
2961334 to
887b0f3
Compare
Signed-off-by: diyliv <onlogn081@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Example
A ConfigMap can contain another YAML stream as plain string data. Helm and Kubernetes accept this manifest: the
|2marker starts a YAML literal block scalar with an explicit indentation indicator, so the nested---is just text insidedata.apply-on-startup.yaml.Before the fix, DMT only recognized
|,|-,>, and>-as multiline scalar markers. It did not recognize|2, so the rendered manifest splitter treated the indented---as a Kubernetes document separator.As a result, DMT effectively tried to parse the second half as a standalone manifest:
That could fail during manifest unmarshalling with an error like:
After the fix, DMT recognizes block scalar values by prefix, so
|2,|+,|-2,>2, and similar valid YAML forms enter multiline mode. The embedded---stays inside the ConfigMap string value, and DMT parses the whole ConfigMap as one rendered Kubernetes manifest.