[Deepin-Kernel-SIG] [linux 6.6.y] [FROMLIST] [AMD]x86/CPU/AMD: Add family 0x1a models 0xd0 through 0xef#1799
Conversation
Family 0x1a model 0xd0, 0xe0 should have X86_FEATURE_ZEN6 Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com> [WangYuli: Fix conflicts] Link: https://lore.kernel.org/lkml/20260530061819.9721-1-Pratik.Vishwakarma@amd.com/ Signed-off-by: WangYuli <wangyl5933@chinaunicom.cn>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExtends the AMD Zen 6 CPU model range detection so that additional family 0x1a models (0xd0–0xef) are recognized as having the X86_FEATURE_ZEN6 capability during BSP initialization. Flow diagram for updated Zen6 feature detection in bsp_init_amdflowchart TD
A[bsp_init_amd]
A --> B{family == 0x1a}
B -- no --> Z[other handling]
B -- yes --> C{model in 0x50-0x5f,
0x90-0xaf,
0xc0-0xef?}
C -- no --> Z
C -- yes --> D["setup_force_cpu_cap(X86_FEATURE_ZEN6)"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a short code comment near the model range explaining why 0xc0 through 0xef are all treated as ZEN6, to help future maintainers understand that this is intentional and based on AMD model allocations.
- Double-check that extending the range to 0xef does not inadvertently include reserved or future non‑Zen6 models; if only specific subranges are guaranteed Zen6, it may be safer to encode them explicitly rather than as one large continuous range.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a short code comment near the model range explaining why 0xc0 through 0xef are all treated as ZEN6, to help future maintainers understand that this is intentional and based on AMD model allocations.
- Double-check that extending the range to 0xef does not inadvertently include reserved or future non‑Zen6 models; if only specific subranges are guaranteed Zen6, it may be safer to encode them explicitly rather than as one large continuous range.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR updates AMD Zen-generation detection for family 0x1a CPUs so that additional model IDs are recognized as Zen6 and get X86_FEATURE_ZEN6 set during boot CPU initialization.
Changes:
- Expand the
family 0x1aZen6 model range from0xc0 ... 0xcfto0xc0 ... 0xefinbsp_init_amd().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: opsiff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Family 0x1a model 0xd0, 0xe0 should have X86_FEATURE_ZEN6
[WangYuli: Fix conflicts]
Link: https://lore.kernel.org/lkml/20260530061819.9721-1-Pratik.Vishwakarma@amd.com/
Summary by Sourcery
Enhancements: