Skip to content

[Deepin-Kernel-SIG] [linux 6.6.y] [FROMLIST] [AMD]x86/CPU/AMD: Add family 0x1a models 0xd0 through 0xef#1799

Merged
opsiff merged 1 commit into
deepin-community:linux-6.6.yfrom
Avenger-285714:0xef-6.6
Jun 3, 2026
Merged

[Deepin-Kernel-SIG] [linux 6.6.y] [FROMLIST] [AMD]x86/CPU/AMD: Add family 0x1a models 0xd0 through 0xef#1799
opsiff merged 1 commit into
deepin-community:linux-6.6.yfrom
Avenger-285714:0xef-6.6

Conversation

@Avenger-285714
Copy link
Copy Markdown
Member

@Avenger-285714 Avenger-285714 commented Jun 2, 2026

Family 0x1a model 0xd0, 0xe0 should have X86_FEATURE_ZEN6

[WangYuli: Fix conflicts]
Link: https://lore.kernel.org/lkml/20260530061819.9721-1-Pratik.Vishwakarma@amd.com/

Summary by Sourcery

Enhancements:

  • Broaden the model ID range that is recognized as supporting X86_FEATURE_ZEN6 for AMD family 0x1a CPUs.

Family 0x1a model 0xd0, 0xe0 should have X86_FEATURE_ZEN6

Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>
[WangYuli: Fix conflicts]
Link: https://lore.kernel.org/lkml/20260530061819.9721-1-Pratik.Vishwakarma@amd.com/
Signed-off-by: WangYuli <wangyl5933@chinaunicom.cn>
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 2, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Extends the AMD Zen 6 CPU model range detection so that additional family 0x1a models (0xd0–0xef) are recognized as having the X86_FEATURE_ZEN6 capability during BSP initialization.

Flow diagram for updated Zen6 feature detection in bsp_init_amd

flowchart TD
    A[bsp_init_amd]
    A --> B{family == 0x1a}
    B -- no --> Z[other handling]
    B -- yes --> C{model in 0x50-0x5f,
0x90-0xaf,
0xc0-0xef?}
    C -- no --> Z
    C -- yes --> D["setup_force_cpu_cap(X86_FEATURE_ZEN6)"]
Loading

File-Level Changes

Change Details Files
Broaden Zen 6 feature attribution to more AMD family 0x1a CPU models during BSP initialization.
  • Update the AMD CPU family/model switch to include models 0xd0–0xef in the range that sets X86_FEATURE_ZEN6
  • Ensure that newly added models automatically receive Zen 6 feature flags during CPU capability setup
arch/x86/kernel/cpu/amd.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding a short code comment near the model range explaining why 0xc0 through 0xef are all treated as ZEN6, to help future maintainers understand that this is intentional and based on AMD model allocations.
  • Double-check that extending the range to 0xef does not inadvertently include reserved or future non‑Zen6 models; if only specific subranges are guaranteed Zen6, it may be safer to encode them explicitly rather than as one large continuous range.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding a short code comment near the model range explaining why 0xc0 through 0xef are all treated as ZEN6, to help future maintainers understand that this is intentional and based on AMD model allocations.
- Double-check that extending the range to 0xef does not inadvertently include reserved or future non‑Zen6 models; if only specific subranges are guaranteed Zen6, it may be safer to encode them explicitly rather than as one large continuous range.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates AMD Zen-generation detection for family 0x1a CPUs so that additional model IDs are recognized as Zen6 and get X86_FEATURE_ZEN6 set during boot CPU initialization.

Changes:

  • Expand the family 0x1a Zen6 model range from 0xc0 ... 0xcf to 0xc0 ... 0xef in bsp_init_amd().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@opsiff opsiff merged commit b422c2a into deepin-community:linux-6.6.y Jun 3, 2026
14 of 16 checks passed
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opsiff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants