Skip to content

feat: Add run_async method for LLMMetadataExtractor#10984

Merged
sjrl merged 3 commits intodeepset-ai:mainfrom
maxdswain:llmmetadataextractor-run-async
Apr 2, 2026
Merged

feat: Add run_async method for LLMMetadataExtractor#10984
sjrl merged 3 commits intodeepset-ai:mainfrom
maxdswain:llmmetadataextractor-run-async

Conversation

@maxdswain
Copy link
Copy Markdown
Contributor

@maxdswain maxdswain commented Mar 30, 2026

Related Issues

Proposed Changes:

Add run_async method for LLMMetadataExtractor.

How did you test it?

Added new unit and integration tests mirroring the existing tests for the run method.

Notes for the reviewer

When developing I got a type error due to the fact that the ChatGenerator protocol does not have a run_async method, I have ignored this for now, but it may be worth thinking about whether that should be added.

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

@maxdswain is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Mar 30, 2026
@sjrl sjrl self-requested a review March 31, 2026 07:36
sjrl
sjrl reviewed Mar 31, 2026
View reviewed changes
Comment thread haystack/components/extractors/llm_metadata_extractor.py Outdated
sjrl
sjrl reviewed Mar 31, 2026
View reviewed changes
Comment thread releasenotes/notes/llmmetadataextractor-run-async-985cfc11c5983afd.yaml Outdated
sjrl
sjrl reviewed Mar 31, 2026
View reviewed changes
Comment thread haystack/components/extractors/llm_metadata_extractor.py
sjrl
sjrl reviewed Mar 31, 2026
View reviewed changes
Comment thread test/components/extractors/test_llm_metadata_extractor.py Outdated
@maxdswain maxdswain requested a review from a team as a code owner April 2, 2026 11:16
@maxdswain maxdswain requested review from sjrl and removed request for a team April 2, 2026 11:16
@maxdswain
Copy link
Copy Markdown
Contributor Author

maxdswain commented Apr 2, 2026

Thanks for the review @sjrl, I should have now addressed all of your comments.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Apr 2, 2026 0:04am

Request Review

sjrl
sjrl reviewed Apr 2, 2026
View reviewed changes
Comment thread haystack/components/extractors/llm_metadata_extractor.py Outdated
sjrl
sjrl approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@sjrl sjrl enabled auto-merge (squash) April 2, 2026 12:33
@sjrl sjrl merged commit 04a0778 into deepset-ai:main Apr 2, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrl sjrl sjrl approved these changes

Assignees

No one assigned

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add run_async method for LLMMetadataExtractor

2 participants

@maxdswain @sjrl