chore: deprecate scatterFactoringTableByType method#176
Open
stevenhua0320 wants to merge 1 commit intodiffpy:mainfrom
Open
chore: deprecate scatterFactoringTableByType method#176stevenhua0320 wants to merge 1 commit intodiffpy:mainfrom
stevenhua0320 wants to merge 1 commit intodiffpy:mainfrom
Conversation
Contributor
|
I think we should move the lookup tables out of diffpy.srreal. if we do that, can we remove srreal as a dependency? This would be much better. |
Contributor
Author
|
I think somewhere it also uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge We need to keep this open for a while as right now we didn't list
diffpy.srrealas a dependency. When we release the new version ofdiffpy.srrealwe can add this back to our requirements and rerun the test. This closes #137