Skip to content

fix goofy link styling#25326

Merged
akristen merged 1 commit into
docker:mainfrom
akristen:fast-follows
Jun 11, 2026
Merged

fix goofy link styling#25326
akristen merged 1 commit into
docker:mainfrom
akristen:fast-follows

Conversation

@akristen

Copy link
Copy Markdown
Contributor

goofy link

@akristen akristen requested a review from craig-osterhout June 10, 2026 17:20
@akristen akristen self-assigned this Jun 10, 2026
@github-actions github-actions Bot added the area/admin Relates to Docker Admin label Jun 10, 2026

@docker-agent docker-agent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The change shortens the link anchor text from a long phrase ("provisioning with System for Cross-domain Identity Management (SCIM) or Just-in-Time (JIT)") to just "provisioning", moving the parenthetical content outside the link as plain text. This aligns with the style guide recommendation for concise, ~5-word descriptive link text. No issues found.

@akristen akristen marked this pull request as ready for review June 10, 2026 17:24
@netlify

netlify Bot commented Jun 10, 2026

Copy link
Copy Markdown

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 8fe0a03
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a299cd58fc1ac0008f01397
😎 Deploy Preview https://deploy-preview-25326--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@thaJeztah

Copy link
Copy Markdown
Member

Before/after;

Screenshot 2026-06-10 at 19 55 48 Screenshot 2026-06-10 at 19 56 22

Generally, I like slightly longer link-captions, but yeah, I guess it's hard to make the cut here; perhaps "provisioning with System" could work as alternative?

(not a blocker from my side, just thinking out loud)

@thaJeztah

Copy link
Copy Markdown
Member

Generally, I like slightly longer link-captions, but yeah, I guess it's hard to make the cut here; perhaps "provisioning with System" could work as alternative?

Ignore me; I was reading it as "systemd" 😂

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akristen akristen merged commit f9c8846 into docker:main Jun 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/admin Relates to Docker Admin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants