Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the diffusers backend, allowing the scheduler to handle models in DDUF and legacy diffusers formats. The backend selection logic has been refactored into a switch statement, and corresponding platform support checks and unit tests have been added. A critical issue was identified regarding a potential nil pointer dereference when logging warnings for incompatible backends, as the backend object could be nil in certain scenarios.
e4dafab to
4b24cd9
Compare
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
selectBackendForModelbranches for safetensors and DDUF/diffusers duplicate the pattern of computingbackendNameand logging a warning; consider extracting this into a small helper to keep the function shorter and reduce repetition. - In
select_backend_test.go, the tests hardcode the "llamacpp" string for backend keys and expected backend names; usingllamacpp.Nameinstead would avoid drift if the backend name ever changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `selectBackendForModel` branches for safetensors and DDUF/diffusers duplicate the pattern of computing `backendName` and logging a warning; consider extracting this into a small helper to keep the function shorter and reduce repetition.
- In `select_backend_test.go`, the tests hardcode the "llamacpp" string for backend keys and expected backend names; using `llamacpp.Name` instead would avoid drift if the backend name ever changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
doringeman
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #793 This pull request enhances the backend selection logic in the inference scheduler to add support for DDUF/diffusers model formats.