Skip to content

Lowercase model names in ps output #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doringeman merged 2 commits into from
Apr 6, 2026
+2 −3
Merged

Lowercase model names in ps output #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa50f26
Lowercase model names in ps output
tmchow Apr 4, 2026
249bb42
fix: lowercase before stripping defaults for mixed-case model names
tmchow Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/cli/commands/ps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func psTable(ps []desktop.BackendStatus) string {
if strings.HasPrefix(modelName, "sha256:") {
modelName = modelName[7:19]
} else {
modelName = stripDefaultsFromModelName(modelName)
modelName = stripDefaultsFromModelName(strings.ToLower(modelName))
}

table.Append([]string{
Expand Down
3 changes: 1 addition & 2 deletions e2e/cli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ func TestE2E_CLI(t *testing.T) {
if err != nil {
t.Fatalf("cli ps failed: %v\noutput: %s", err, out)
}
// TODO: ps should return lowercased model names like ls does
if !strings.Contains(strings.ToLower(out), "smollm2") {
if !strings.Contains(out, "smollm2") {
t.Errorf("expected model in ps output, got:\n%s", out)
}
if !strings.Contains(out, bc.name) {
Expand Down
Loading