Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts table query behavior to avoid duplicate data loading when using virtual scroll, by gating initial query execution based on scroll mode and tracking first-query state in the virtualized items provider. Sequence diagram for table query behavior with virtual scrollsequenceDiagram
participant Table as Table
participant Virtualize as Virtualize
alt ScrollMode_None
Table->>Table: OnAfterRenderAsync(firstRender)
Table->>Table: QueryAsync(isInit true, pageIndex 1,
Table->>Table: StateHasChanged()
else ScrollMode_Virtual
Table->>Table: OnAfterRenderAsync(firstRender)
Table->>Table: StateHasChanged()
Virtualize->>Table: LoadItems(request)
Table->>Table: ToggleLoading(true)
Table->>Table: QueryData(triggerByPagination false, firstQuery true)
Table->>Table: ToggleLoading(false)
Note right of Table: isFirstQuery set to false after first QueryData
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
isFirstQueryflag is never reset, so if the data source, filters, orScrollModechange over the lifetime of the component, subsequent virtual-scroll sessions may incorrectly skip the 'first query' behavior; consider resetting it when relevant component state changes (e.g., data source or scroll mode changes, or on reinitialization). - In
OnAfterRenderAsync, the newStateHasChanged()call in theScrollMode != Nonebranch can easily cause an extra render loop; if this is only needed on the initial render or under specific conditions, consider guarding it withfirstRenderor a more precise condition to avoid unnecessary re-renders.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `isFirstQuery` flag is never reset, so if the data source, filters, or `ScrollMode` change over the lifetime of the component, subsequent virtual-scroll sessions may incorrectly skip the 'first query' behavior; consider resetting it when relevant component state changes (e.g., data source or scroll mode changes, or on reinitialization).
- In `OnAfterRenderAsync`, the new `StateHasChanged()` call in the `ScrollMode != None` branch can easily cause an extra render loop; if this is only needed on the initial render or under specific conditions, consider guarding it with `firstRender` or a more precise condition to avoid unnecessary re-renders.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8071 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 766 766
Lines 34163 34171 +8
Branches 4699 4700 +1
=========================================
+ Hits 34163 34171 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #8065
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Avoid duplicate data queries when using virtual scroll in the table component and ensure appropriate UI updates on initial render.
Bug Fixes:
Enhancements: