KIP-559: bump JoinGroup v7 / SyncGroup v5; verify protocol_type/name#2998
Merged
Conversation
KIP-559 makes the Kafka protocol friendlier with L7 proxies by ensuring that JoinGroup and SyncGroup messages explicitly carry the group's ProtocolType / ProtocolName, so each message can be parsed independently. The wire schemas already covered the new fields (JoinGroup v7, SyncGroup v5 — both via generated stubs). Apply the client-side bits: - coordinator/base: send JoinGroupRequest max_version=7, SyncGroupRequest max_version=5, populating protocol_type and protocol_name on the SyncGroupRequest. - coordinator/base: validate response.protocol_type on the JoinGroupResponse and both protocol_type and protocol_name on the SyncGroupResponse; raise InconsistentGroupProtocolError on mismatch (treated equivalently to a broker-reported INCONSISTENT_GROUP_PROTOCOL). - tests: cover join/sync protocol_type and sync protocol_name mismatches. Co-authored-by: Shelley <shelley@exe.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KIP-559 makes the Kafka protocol friendlier with L7 proxies by ensuring
that JoinGroup and SyncGroup messages explicitly carry the group's
ProtocolType / ProtocolName, so each message can be parsed independently.
The wire schemas already covered the new fields (JoinGroup v7,
SyncGroup v5 — both via generated stubs). Apply the client-side bits:
SyncGroupRequest max_version=5, populating protocol_type and
protocol_name on the SyncGroupRequest.
JoinGroupResponse and both protocol_type and protocol_name on the
SyncGroupResponse; raise InconsistentGroupProtocolError on mismatch
(treated equivalently to a broker-reported INCONSISTENT_GROUP_PROTOCOL).
Co-authored-by: Shelley shelley@exe.dev