Use base e2b SDK in tests that don't need code-interpreter#2204
Use base e2b SDK in tests that don't need code-interpreter#2204
Conversation
internet-works.ts, time-is-synchronized, and utils.ts only use sandbox.commands.run() and sandbox lifecycle methods, which are available in the base e2b SDK. Only run-code.ts and snapshot-and-resume.ts actually need code-interpreter for runCode().
tests/periodic-test/package.json
Outdated
| "@e2b/code-interpreter": "^2.3.3", | ||
| "e2b": "^2.3.0" |
There was a problem hiding this comment.
is this the code-interpreter 2.3.3 version? Would it make sense to update to latest?
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f09227059
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
tests/periodic-test/package.json
Outdated
| "@e2b/cli": "^2.7.3", | ||
| "@e2b/code-interpreter": "^2.3.3" | ||
| "@e2b/code-interpreter": "^2.3.3", | ||
| "e2b": "^2.3.0" |
There was a problem hiding this comment.
This adds e2b to tests/periodic-test/package.json but does not update tests/periodic-test/bun.lock, which makes the dependency manifest inconsistent. In the periodic test workflow I checked (.github/workflows/periodic-test.yml, install step at lines 88-90), dependencies are installed with bun install --frozen-lockfile, so this mismatch will cause CI to fail before any test executes.
Useful? React with 👍 / 👎.
Update @e2b/code-interpreter to ^2.4.0 and e2b to ^2.15.0. Also regenerates bun.lock to fix frozen-lockfile CI failures.
2 participants
Summary
internet-works.ts,time-is-synchronized/index.ts, andutils.tsonly usesandbox.commands.run()and sandbox lifecycle methods — norunCode()needede2binstead of@e2b/code-interpretere2bas explicit dependency in package.jsonrun-code.tsandsnapshot-and-resume.tsstill correctly use@e2b/code-interpreter(they callrunCode())Test plan