procedures: clarify conditional registry auth secret copying for DevWorkspace backups#3091
Closed
tolusha wants to merge 1 commit into
Closed
procedures: clarify conditional registry auth secret copying for DevWorkspace backups#3091tolusha wants to merge 1 commit into
tolusha wants to merge 1 commit into
Conversation
…orkspace backups Update documentation to reflect the new conditional secret copying behavior introduced in devfile/devworkspace-operator#1618: - The operator only copies registry auth secrets when authSecret is configured - User-provided secrets in workspace namespaces are never overwritten - When no authSecret is configured, anonymous registry access is assumed - Clarify that authSecret specifies the secret name in the operator namespace - The secret copied to workspace namespaces always uses the canonical name Updated articles: - modules/administration-guide/pages/devworkspace-backup-regular-oci-registry.adoc - modules/administration-guide/pages/devworkspace-backup.adoc Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
tolusha
requested review from
a team,
deerskindoll,
gtrivedi88 and
mkuznyetsov
as code owners
|
🎊 Navigate the preview: 🎊 |
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
Updates the DevWorkspace backup documentation to accurately reflect the conditional registry authentication secret copying behavior introduced in devfile/devworkspace-operator#1618.
The key changes documented:
authSecretfield is configured inDevWorkspaceOperatorConfigauthSecretis configured, the backup job assumes anonymous registry access (for public registries)authSecretspecifies the secret name in the operator installation namespace, not the workspace namespacedevworkspace-backup-registry-authArticles updated:
modules/administration-guide/pages/devworkspace-backup-regular-oci-registry.adoc- Replaced the WARNING section with a comprehensive IMPORTANT section explaining the conditional copying logic, updated command examples to include namespace specificationmodules/administration-guide/pages/devworkspace-backup.adoc- Clarified theregistry.authSecretfield description to explain conditional copyingWhat issues does this pull request fix or reference?
Specify the version of the product this pull request applies to
next
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.