[Win32] Add double-dispose guard in DestroyableImageHandle.destroy()#3243
Open
HeikoKlare wants to merge 1 commit intoeclipse-platform:masterfrom
Open
[Win32] Add double-dispose guard in DestroyableImageHandle.destroy()#3243HeikoKlare wants to merge 1 commit intoeclipse-platform:masterfrom
HeikoKlare wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
The destroy() method did not check the isDisposed flag before calling OS.DestroyIcon/OS.DeleteObject. If called twice, it would pass an already-freed handle to the OS, risking undefined behavior. Add an early return when the handle is already disposed.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DestroyableImageHandle.destroy()to prevent passing an already-freed GDI handle toOS.DestroyIcon/OS.DeleteObjectwhendestroy()is called more than onceisDisposedflag was already being set at the end ofdestroy()but was not checked on entryTest plan
🤖 Generated with Claude Code