Skip to content

🐛 fix(auth): avoid race when storing fingerprint sessions #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitbacchus merged 3 commits into from
May 20, 2026
Merged

🐛 fix(auth): avoid race when storing fingerprint sessions #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b25fd95
fix(backend): use user uid (not fingerprint uid) when blocking/unbloc…
claude May 20, 2026
526c7f1
fix(backend): await session-store update before completing WS handshake
claude May 20, 2026
d9651d3
Merge pull request #121 from bitbacchus/claude/fix-auth-race-conditio…
bitbacchus May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/backend/src/actors/FingerprintStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export class FingerprintStore extends SubscribableActor<Fingerprint, Fingerprint
this.storeEntity({...fp, blocked: true});
this.updateSubscribers({...fp, blocked: true})
if (uid)
this.send("actors://recapp-backend/UserStore", UserStoreMessages.Update({ uid: fp.uid, active: false }));
this.send("actors://recapp-backend/UserStore", UserStoreMessages.Update({ uid, active: false }));
return unit();
},
() => {
Expand All @@ -89,7 +89,7 @@ export class FingerprintStore extends SubscribableActor<Fingerprint, Fingerprint
this.storeEntity({...fp, blocked: false});
this.updateSubscribers({...fp, blocked: false})
if (uid)
this.send("actors://recapp-backend/UserStore", UserStoreMessages.Update({ uid: fp.uid, active: true }));
this.send("actors://recapp-backend/UserStore", UserStoreMessages.Update({ uid, active: true }));
return unit();
},
() => {
Expand Down
4 changes: 2 additions & 2 deletions packages/backend/src/middlewares/authMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ export const authenticationMiddleware = (request: IncomingMessage, next: (err: E
.map(bearerValid)
.orElse(Promise.resolve("" as Id)) as Promise<Id>;
tokenValid
.then(uid => {
.then(async uid => {
if (!uid) {
next(authorizationError());
return;
}
Container.get<ActorSystem>("actor-system").send(
await Container.get<ActorSystem>("actor-system").ask(
createActorUri("SessionStore"),
SessionStoreMessages.StoreSession({ uid, actorSystem })
);
Expand Down
Loading