[WasmFS] Use const uint8_t* in JS API impl. NFC#24706
Merged
kleisauke merged 4 commits intoemscripten-core:mainfrom Apr 6, 2026
Merged
[WasmFS] Use const uint8_t* in JS API impl. NFC#24706kleisauke merged 4 commits intoemscripten-core:mainfrom
const uint8_t* in JS API impl. NFC#24706kleisauke merged 4 commits intoemscripten-core:mainfrom
Conversation
Collaborator
Author
|
Test failures are due to https://discourse.llvm.org/t/llvm-21-x-release-branch-created-main-is-now-22/87374. |
Collaborator
sbc100
reviewed
Apr 5, 2026
system/lib/wasmfs/js_api.cpp
Outdated
| // Writes to a file, possibly creating it, and returns the number of bytes | ||
| // written successfully. If the file already exists, appends to it. | ||
| int _wasmfs_write_file(const char* pathname, char* data, size_t data_size) { | ||
| int _wasmfs_write_file(const char* pathname, const char* data, size_t data_size) { |
Collaborator
There was a problem hiding this comment.
I wonder why we don't use uint8_t here to like that .write method below does?
Collaborator
Author
sbc100
approved these changes
Apr 5, 2026
kleisauke
changed the title
const char* in JS API impl. NFCconst uint8_t* in JS API impl. NFC
sbc100
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In line with #23825.