file_packager.py: Enable to run without additional envvar setup for basic usage#26630
Draft
ktock wants to merge 3 commits intoemscripten-core:mainfrom
Draft
file_packager.py: Enable to run without additional envvar setup for basic usage#26630ktock wants to merge 3 commits intoemscripten-core:mainfrom
ktock wants to merge 3 commits intoemscripten-core:mainfrom
Conversation
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
sbc100
changed the title
Collaborator
|
My plan for making this work is to make all the initialization for things like shared.py happen after import time. I started work in #25851 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #21529
file_packager.py requires setting up additional environment variables even when the user doesn't specify flags that depend on emcc (e.g. --obj-output).
This commit solves this issue by removing the dependency on shared.py from file_packager.py unless the user specifies the flag that depends on them. This allows the user to use the script without setting up the additional environment variable for basic usage.