[bp/1.37] [stack] stats number limit and scope level stats matcher support#44085
Draft
wbpcode wants to merge 3 commits intoenvoyproxy:release/v1.37from
Draft
[bp/1.37] [stack] stats number limit and scope level stats matcher support#44085wbpcode wants to merge 3 commits intoenvoyproxy:release/v1.37from
wbpcode wants to merge 3 commits intoenvoyproxy:release/v1.37from
Conversation
Commit Message: add support for limiting the max number of stats(counter/gauge/histogram) per scope. This helps with memory explosion caused by high cardinality stats. Risk Level: low Testing: unit test covered Docs Changes: no doc update as it is a library support for internal usage Release Notes: updated Platform Specific Features: no --------- Signed-off-by: Xuyang Tao <taoxuy@google.com>
…ts (envoyproxy#43899) Commit Message: stats: add additional scope level stats matcher to enable/disable stats Additional Description: Part of envoyproxy#43847. This PR add an optional stats matcher as constructor parameter of Scope. If the scope level stats matcher is enabled, it will take priority over the global stats matcher. Risk Level: mid (core code change). Testing: n/a. Docs Changes: n/a Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com> Signed-off-by: wbpcode <wbphub@gmail.com>
Member
Author
|
I will review this first to ensure there is no high risk change first. And then, let other maintainer to review this. Three commit are cherry-picked without conflicts (except change log). The force push is used to fix the last commit's sign. |
…oyproxy#43923) Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
wbpcode
force-pushed
the
dev-feat-1.37-fine-grained-stats
branch
from
3865a6f to
5f5fc23
Compare
Member
|
failure looks like it might be real /retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: [bp/1.37] [stack] stats number limit and scope level stats matcher support
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]