feat: attempt at unified stateful test#4263
Open
asvae wants to merge 1 commit intoepicmaxco:developfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I attempted to somewhat unify a feature test. I took stateful as a simplest case. We may want to merge it its incomplete state or attempt to apply to other components, making this PR more useful.
I would like this test to be sort of like
statefulWorksFor(VaComponent, testDetails).I only managed to make it work with 2 components, and even that wasn't perfect (click on root element didn't work).
For VaCounter the problematic part was that it didn't even support
data-testidon root element. (I detailed in #4262)