docs(design-system-docs): document Divider for EDS 2.0#4875
docs(design-system-docs): document Divider for EDS 2.0#4875
Conversation
Rewrites the Divider page for the new next/Divider component, moves it from Data Display to Surfaces, and registers a Surfaces sidebar category. Closes #4701
|
@claude review |
|
Claude finished @pomfrida's task in 1m 45s —— View job Code Review
Overall this is a clean, well-structured docs page. The content is accurate against the component implementation. A few observations below. Verified correct
Issues1.
2. Outdated WAI-ARIA spec link
The current version is 1.2. Consider updating to: Suggestions3. Missing import/usage example Other EDS 2.0 docs (e.g. ## Usage
```tsx
import { Divider } from '@equinor/eds-core-react/next'
<Divider /> |
pomfrida
left a comment
There was a problem hiding this comment.
Small nits, will approve after 👍
| - Use dividers occasionally, to create groupings rather than separate individual items | ||
| - Dividers should be noticeable in a layout, but not clashing | ||
| - Dividers should only be used if elements can't be split using white space | ||
| - Dividers can help establish rhythm and hierarchy |
There was a problem hiding this comment.
Line 8 and 27 is kind of identical - is it needed here?
|
|
||
| ## Accessibility | ||
|
|
||
| Dividers follow the [WAI-ARIA separator pattern](https://www.w3.org/TR/2017/REC-wai-aria-1.1-20171214/#separator) and render as a non-interactive `<hr>` element with `role="separator"`. |
There was a problem hiding this comment.
| Dividers follow the [WAI-ARIA separator pattern](https://www.w3.org/TR/2017/REC-wai-aria-1.1-20171214/#separator) and render as a non-interactive `<hr>` element with `role="separator"`. | |
| Dividers follow the [WAI-ARIA separator pattern](https://www.w3.org/TR/2017/REC-wai-aria-1.1-20171214/#separator) and renders as a native `<hr>`, which has the implicit ARIA role separator.`. |
Summary
next/Dividercomponent (replaces the empty stub)sidebars.tsTest plan
pnpm --filter design-system-docs startand verify the Divider page renders under Surfaces in the sidebareds-2-0-beta-surface-divider--introductionData Displaycategory no longer lists DividerCloses #4701