Security: Hardcoded default API token enables predictable authentication#13336
Open
tomaioo wants to merge 1 commit intoequinor:mainfrom
Open
Security: Hardcoded default API token enables predictable authentication#13336tomaioo wants to merge 1 commit intoequinor:mainfrom
tomaioo wants to merge 1 commit intoequinor:mainfrom
Conversation
Authentication falls back to a hardcoded token (`DEFAULT_TOKEN = "hunter2"`) when `ERT_STORAGE_TOKEN` is not set. If operators forget to configure the environment variable, attackers can authenticate using a publicly known default credential. Signed-off-by: tomaioo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Hardcoded default API token enables predictable authentication
Problem
Severity:
High| File:src/ert/dark_storage/security.py:L6Authentication falls back to a hardcoded token (
DEFAULT_TOKEN = "hunter2") whenERT_STORAGE_TOKENis not set. If operators forget to configure the environment variable, attackers can authenticate using a publicly known default credential.Solution
Remove hardcoded fallback tokens. Require
ERT_STORAGE_TOKENto be explicitly set at startup and fail fast if missing. Consider loading secrets from a secret manager and rotating tokens regularly.Changes
src/ert/dark_storage/security.py(modified)