Skip to content

Use Viridis as colour palette for Ert and Everest#13414

Open
berland wants to merge 11 commits intoequinor:mainfrom
berland:viridis
Open

Use Viridis as colour palette for Ert and Everest#13414
berland wants to merge 11 commits intoequinor:mainfrom
berland:viridis

Conversation

@berland
Copy link
Copy Markdown
Contributor

@berland berland commented Apr 24, 2026

Issue
Resolves #13288

Approach
Calculate hex values via Matplotlib, and pick discrete colours in a specific fashion to maximise separation.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@berland

This comment was marked as outdated.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.36%. Comparing base (d5f13f9) to head (cb1b66c).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13414      +/-   ##
==========================================
- Coverage   89.99%   85.36%   -4.64%     
==========================================
  Files         460      460              
  Lines       32320    32332      +12     
==========================================
- Hits        29087    27599    -1488     
- Misses       3233     4733    +1500     
Flag Coverage Δ
cli-tests 37.23% <ø> (+<0.01%) ⬆️
fuzz 44.06% <ø> (-0.02%) ⬇️
gui-tests ?
performance-and-unit-tests 78.09% <ø> (+0.02%) ⬆️
test 45.62% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 70 files with indirect coverage changes

@berland

This comment was marked as outdated.

@berland berland force-pushed the viridis branch 3 times, most recently from 4d724b2 to 8c32f8b Compare May 6, 2026 10:16
berland added 3 commits May 6, 2026 12:46
The comment prohibited the action from finding any files at all.
5 colour map posision values between 0 and 1 have been hand-picked for
"pretty" appearance in the GUI.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 6, 2026

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing berland:viridis (ae9f9b8) with main (beb9d13)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change discrete colour palette to viridis

2 participants