Skip to content

Optimize localization memory with broadcast_to#13419

Open
dafeda wants to merge 1 commit intoequinor:mainfrom
dafeda:broadcast-to-memory
Open

Optimize localization memory with broadcast_to#13419
dafeda wants to merge 1 commit intoequinor:mainfrom
dafeda:broadcast-to-memory

Conversation

@dafeda
Copy link
Copy Markdown
Collaborator

@dafeda dafeda commented Apr 27, 2026

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@dafeda dafeda self-assigned this Apr 27, 2026
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Apr 27, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (1b5208a) to head (b56367e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13419      +/-   ##
==========================================
- Coverage   90.03%   90.02%   -0.02%     
==========================================
  Files         459      459              
  Lines       31986    31991       +5     
==========================================
+ Hits        28799    28800       +1     
- Misses       3187     3191       +4     
Flag Coverage Δ
cli-tests 37.47% <55.55%> (-0.01%) ⬇️
fuzz 44.23% <0.00%> (-0.01%) ⬇️
gui-tests 66.89% <0.00%> (-0.05%) ⬇️
performance-and-unit-tests 78.03% <77.77%> (-0.02%) ⬇️
test 45.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ert/analysis/_update_strategies/_distance.py 76.47% <100.00%> (+1.47%) ⬆️

... and 1 file with indirect coverage changes

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 27, 2026

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing dafeda:broadcast-to-memory (b56367e) with main (1b5208a)

Open in CodSpeed

nxy = ertbox.nx * ertbox.ny
rho_2d = rho_matrix.reshape(nxy, -1)

if ertbox.nz > 1:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth it to have the two separate branches here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:skip If there should be no mention of this in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants