Cover array input for req.acceptsCharsets()#7195
Closed
Bojun-Vvibe wants to merge 1 commit intoexpressjs:masterfrom
Closed
Cover array input for req.acceptsCharsets()#7195Bojun-Vvibe wants to merge 1 commit intoexpressjs:masterfrom
req.acceptsCharsets()#7195Bojun-Vvibe wants to merge 1 commit intoexpressjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo: expressjs/express (⭐ 66000)
Type: test
Files changed: 2
Lines: +23/-9
What
Adds a focused test that covers passing an array to
req.acceptsCharsets(), and updates thereq.acceptsCharsets()JSDoc inlib/request.jsso it documents the same supported input forms and return behavior as the rest of thereq.accepts*helpers.Why
req.acceptsCharsets()already exposes array-style input through the underlyingacceptsAPI, but that behavior was not covered by tests and the docstring incorrectly described a comma-delimited string form instead. This patch closes that documentation gap and locks the public API behavior down with a small regression test.Testing
Verified syntax for the touched files with
node --check lib/request.jsandnode --check test/req.acceptsCharsets.js. The targeted mocha test was not run locally because this clone does not havenode_modulesinstalled.Risk
Low / documentation-only behavior clarification plus one narrow test for an existing public API path.