Add global exclude patterns to the cxx api config (#56248)#56248
Closed
coado wants to merge 4 commits intofacebook:mainfrom
Closed
Add global exclude patterns to the cxx api config (#56248)#56248coado wants to merge 4 commits intofacebook:mainfrom
coado wants to merge 4 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
p: Software Mansion
cortinico
approved these changes
Mar 27, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
coado
added a commit
to coado/react-native
that referenced
this pull request
Mar 27, 2026
Summary: Refactor and add global exclude patterns to the C++ stable API snapshot config. This enables better modularization of shared exclude patterns coming from the assumption that ReactAndroid and ReactApple consists of ReactCommon in their inputs and some paths should not be processed on each platform. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D97465431
meta-codesync
bot
changed the title
coado
added a commit
to coado/react-native
that referenced
this pull request
Mar 27, 2026
Summary: Refactor and add global exclude patterns to the C++ stable API snapshot config. This enables better modularization of shared exclude patterns coming from the assumption that ReactAndroid and ReactApple consists of ReactCommon in their inputs and some paths should not be processed on each platform. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D97465431
coado
added a commit
to coado/react-native
that referenced
this pull request
Mar 27, 2026
Summary: Pull Request resolved: facebook#56248 Refactor and add global exclude patterns to the C++ stable API snapshot config. This enables better modularization of shared exclude patterns coming from the assumption that ReactAndroid and ReactApple consists of ReactCommon in their inputs and some paths should not be processed on each platform. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D97465431
added 3 commits
March 31, 2026 04:30
Summary: This diff introduces initial snapshots of the Cxx public API in a form of a couple .api files, namely: - ReactAndroidDebugCxx.api - ReactAndroidReleaseCxx.api - ReactAppleDebugCxx.api - ReactAppleReleaseCxx.api - ReactCommonDebugCxx.api - ReactCommonReleaseCxx.api that is for `ReactAndroid`, `ReactApple`, and shared `ReactCommon` in two variants `Release` and `Debug` each. Differential Revision: D97296573
Summary: Pull Request resolved: facebook#56042 Adds CI workflow for validating whether the current C++ API snapshot is equivalent with the generated one. Changelog: [Internal] Differential Revision: D95963515
Summary: Removes leaked test code from the snapshot. Changelog: [Internal] Differential Revision: D97457090
coado
added a commit
to coado/react-native
that referenced
this pull request
Mar 31, 2026
Summary: Refactor and add global exclude patterns to the C++ stable API snapshot config. This enables better modularization of shared exclude patterns coming from the assumption that ReactAndroid and ReactApple consists of ReactCommon in their inputs and some paths should not be processed on each platform. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D97465431
coado
added a commit
to coado/react-native
that referenced
this pull request
Mar 31, 2026
Summary: Refactor and add global exclude patterns to the C++ stable API snapshot config. This enables better modularization of shared exclude patterns coming from the assumption that ReactAndroid and ReactApple consists of ReactCommon in their inputs and some paths should not be processed on each platform. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D97465431
Summary: Pull Request resolved: facebook#56248 Refactor and add global exclude patterns to the C++ stable API snapshot config. This enables better modularization of shared exclude patterns coming from the assumption that ReactAndroid and ReactApple consists of ReactCommon in their inputs and some paths should not be processed on each platform. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D97465431
|
This pull request has been merged in b0b30b5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor and add global exclude patterns to the C++ stable API snapshot config. This enables better modularization of shared exclude patterns coming from the assumption that ReactAndroid and ReactApple consists of ReactCommon in their inputs and some paths should not be processed on each platform.
Changelog:
[Internal]
Reviewed By: cortinico
Differential Revision: D97465431