fix: Register HeadlessJsTaskSupportModule in CoreReactPackage#56267
Closed
taibin wants to merge 1 commit intofacebook:mainfrom
Closed
fix: Register HeadlessJsTaskSupportModule in CoreReactPackage#56267taibin wants to merge 1 commit intofacebook:mainfrom
taibin wants to merge 1 commit intofacebook:mainfrom
Conversation
The HeadlessJsTaskSupportModule was not included in any ReactPackage, causing AppRegistry.notifyTaskFinished() to fail silently. This meant headless JS tasks would not properly signal completion to the calling service, leaving it to linger unnecessarily. This fix adds HeadlessJsTaskSupportModule to CoreReactPackage so that notifyTaskFinished and notifyTaskRetry methods are properly available. Fixes facebook#56263 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
the
Shared with Meta
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D98884467. |
|
@cortinico merged this pull request in 2d78a39. |
Collaborator
|
This pull request was successfully merged by 贾太滨 in 2d78a39 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
HeadlessJsTaskSupportModulewas not included in any ReactPackage, causingAppRegistry.notifyTaskFinished()to fail silently. This meant headless JS tasks would not properly signal completion to the calling service, leaving it to linger unnecessarily.This fix adds
HeadlessJsTaskSupportModuletoCoreReactPackageso thatnotifyTaskFinishedandnotifyTaskRetrymethods are properly available.Changelog
[ANDROID] [FIXED] - Register HeadlessJsTaskSupportModule in CoreReactPackage
Test Plan
notifyTaskFinished()Fixes #56263
🤖 Generated with Claude Code