harden seek table parsing against overflow and oversized frame metadata#4638
Open
metsw24-max wants to merge 1 commit intofacebook:devfrom
Open
harden seek table parsing against overflow and oversized frame metadata#4638metsw24-max wants to merge 1 commit intofacebook:devfrom
metsw24-max wants to merge 1 commit intofacebook:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hardens seek table parsing in
zstdseek_decompress.cby adding strict bounds checks for untrusted metadata before size arithmetic and memory allocationAdded a hard upper bound check for numFrames from seek table metadata
Added checked arithmetic for table size and frame size computations before multiply/add operations
Added allocation-size overflow guards when allocating seek entries in load path and clone path
These checks reduce memory safety risk by ensuring untrusted metadata cannot trigger wrapped size calculations or undersized allocations.