👷 Replace `mypy` with `ty` in precommit by svlandeg · Pull Request #1806 · fastapi/sqlmodel

svlandeg · 2026-03-09T16:58:48Z

Replace mypy with ty in precommit, lint.sh & pyproject.toml.
Adjust type codes to specific ty codes
Type fixes to make ty happy

I originally set out to have mypy and ty run together in precommit, but for sqlmodel I would argue that perhaps we want to remove mypy alltogether already now, as it allows us to remove a lot of type: ignore statements that ty thinks are unnecessary anyway.

⚠️ This requires thorough review, I'm not super sure on all decisions taken here, cf 2 separate review comments below 👇

github-actions · 2026-03-09T17:01:03Z

📝 Docs preview

Last commit a1e581a at: https://95ee33ac.sqlmodel.pages.dev

…rs are before it (invalid-legacy-positional-parameter)

scripts/generate_select.py

sqlmodel/main.py

# Conflicts: # pyproject.toml # uv.lock

YuriiMotov

Added a few suggestions in the comments. Please, take a look)

sqlmodel/main.py

sqlmodel/sql/_expression_select_cls.py

scripts/generate_select.py

sqlmodel/main.py

svlandeg · 2026-03-18T17:07:43Z

@YuriiMotov, thanks for the review! I addressed everything, looks better IMO 🙂

YuriiMotov · 2026-03-25T12:01:16Z

sqlmodel/main.py


    # Replicate SQLAlchemy
-    def __setattr__(cls, name: str, value: Any) -> None:
+    def __setattr__(cls, name: str, value: Any) -> None:  # ty: ignore[invalid-method-override]


For context: #1806 (comment)

YuriiMotov

LGTM!

Just one moment with removing tests/test_select_typing.py from command

.pre-commit-config.yaml

svlandeg · 2026-03-25T12:29:12Z

Ok, I reviewed it all again, I think it should be fine now 🤞

svlandeg

Putting this back in draft as I have a look into updating ty to 0.0.25, which generates a new host of errors.

svlandeg

Apologies for all the back-and-forth here. I updated the PR to use ty 0.0.25 which is actually nicer. And now we also error on warnings. Should be good for a hopefully final review 🙏

YuriiMotov

All good!

add ty to lint, precommit, pyproject and uv lock

0251f0f

svlandeg added the internal label Mar 9, 2026

svlandeg self-assigned this Mar 9, 2026

svlandeg and others added 9 commits March 9, 2026 19:21

add type annotation to kwargs dict

a52380b

remove unnecessary type ignore statements

3203f83

🎨 Auto format

5d9dd59

avoid using double underscore when any positional-or-keyword paramete…

5c9b1d5

…rs are before it (invalid-legacy-positional-parameter)

one more

c1b0465

remove mypy

732847d

Merge branch 'main' into feat/ty

2f8efa3

use same names as upstream class

dc8593b

fix generator

1dceaa7

svlandeg commented Mar 10, 2026

View reviewed changes

scripts/generate_select.py Outdated Show resolved Hide resolved

svlandeg commented Mar 10, 2026

View reviewed changes

sqlmodel/main.py Outdated Show resolved Hide resolved

svlandeg changed the title ~~👷 Add ty to precommit~~ 👷 Replace mypy with ty in precommit Mar 10, 2026

svlandeg marked this pull request as ready for review March 10, 2026 10:16

svlandeg removed their assignment Mar 10, 2026

github-actions bot added the conflicts Automatically generated when a PR has a merge conflict label Mar 14, 2026

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into feat/ty

02cd800

# Conflicts: # pyproject.toml # uv.lock

github-actions bot removed the conflicts Automatically generated when a PR has a merge conflict label Mar 14, 2026

This comment was marked as resolved.

Sign in to view

github-actions bot added the conflicts Automatically generated when a PR has a merge conflict label Mar 15, 2026

svlandeg self-assigned this Mar 15, 2026

Merge branch 'main' into feat/ty

c49bf7f

# Conflicts: # pyproject.toml # uv.lock

github-actions bot removed the conflicts Automatically generated when a PR has a merge conflict label Mar 16, 2026

svlandeg removed their assignment Mar 16, 2026

svlandeg requested a review from YuriiMotov March 16, 2026 09:15

YuriiMotov reviewed Mar 16, 2026

View reviewed changes

sqlmodel/main.py Outdated Show resolved Hide resolved

sqlmodel/sql/_expression_select_cls.py Show resolved Hide resolved

scripts/generate_select.py Outdated Show resolved Hide resolved

sqlmodel/main.py Outdated Show resolved Hide resolved

svlandeg mentioned this pull request Mar 18, 2026

🐛 Fix pyright errors in type annotations and select() overloads #1820

Closed

estarfoo mentioned this pull request Mar 18, 2026

🐛 Move __tablename__ default from @declared_attr to metaclass #1821

Open

svlandeg and others added 2 commits March 18, 2026 17:23

use / to denote positional-only parameters

277366f

🎨 Auto format

b511af0

svlandeg marked this pull request as draft March 18, 2026 16:29

svlandeg added 3 commits March 18, 2026 17:31

remove class_registry

7aebcc9

revert attr naming and add ty ignore instead

c6e97e7

Merge branch 'main' into feat/ty

9103510

svlandeg marked this pull request as ready for review March 18, 2026 17:07

svlandeg removed their assignment Mar 18, 2026

svlandeg requested a review from YuriiMotov March 24, 2026 12:52

YuriiMotov reviewed Mar 25, 2026

View reviewed changes

YuriiMotov approved these changes Mar 25, 2026

View reviewed changes

.pre-commit-config.yaml Outdated Show resolved Hide resolved

svlandeg added 2 commits March 25, 2026 13:16

ty check tests/test_select_typing.py as well

807d9d6

Merge branch 'main' into feat/ty

51b72e1

svlandeg and others added 2 commits March 26, 2026 23:16

ensure that a ty warning creates an error

fa6df49

🎨 Auto format

0f2ea9c

svlandeg commented Mar 26, 2026

View reviewed changes

svlandeg marked this pull request as draft March 26, 2026 22:18

svlandeg self-assigned this Mar 26, 2026

svlandeg added 3 commits March 26, 2026 23:20

Merge branch 'main' into feat/ty

9cd8a87

upgrade lower ty bound to 0.0.25

fef2ff7

change mypy codes to ty codes

a1e581a

svlandeg marked this pull request as ready for review March 27, 2026 10:44

svlandeg removed their assignment Mar 27, 2026

svlandeg commented Mar 27, 2026

View reviewed changes

svlandeg requested a review from YuriiMotov March 27, 2026 10:45

YuriiMotov approved these changes Mar 27, 2026

View reviewed changes

Uh oh!

Conversation

svlandeg commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Docs preview

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

YuriiMotov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

svlandeg commented Mar 18, 2026

Uh oh!

YuriiMotov Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

YuriiMotov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

svlandeg commented Mar 25, 2026

Uh oh!

svlandeg left a comment

Choose a reason for hiding this comment

Uh oh!

svlandeg left a comment

Choose a reason for hiding this comment

Uh oh!

YuriiMotov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

svlandeg commented Mar 9, 2026 •

edited

Loading

github-actions bot commented Mar 9, 2026 •

edited

Loading