Update main CI job to have name#111
Merged
Merged
Conversation
Right now, GitHub is not showing an option in branch protection rules for this job to be completed as a status check. While I have not seen anything explicitly documented that having unnamed or generic job ids (e.g. build) will cause this to happen, there are recommendations to have jobs be uniquely named to avoid ambiguity and potential problems.
erikrose
approved these changes
Jun 3, 2026
Member
erikrose
left a comment
erikrose
left a comment
There was a problem hiding this comment.
Let's give the simple thing a shot before doing a deep perusal!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, GitHub is not showing an option in branch protection rules for this job to be completed as a status check. While I have not seen anything explicitly documented that having unnamed or generic job ids (e.g. build) will cause this to happen, there are recommendations to have jobs be uniquely named to avoid ambiguity and potential problems.
This change will need to land on main for us to know whether it resolves the problem. Feel free to take a gander at the rules to make sure I'm not missing something obvious as well @erikrose -- what I observed is that PRs are able to be merged before CI completes. Not the end of the world, but makes it easier for a goof to make it into main.