Skip to content

Migrate Home page animation to CSS transitions and remove react-transition-group#5649

Merged
mstange merged 3 commits intofirefox-devtools:mainfrom
mstange:remove-transition-group
Apr 10, 2026
Merged

Migrate Home page animation to CSS transitions and remove react-transition-group#5649
mstange merged 3 commits intofirefox-devtools:mainfrom
mstange:remove-transition-group

Conversation

@mstange
Copy link
Copy Markdown
Contributor

@mstange mstange commented Oct 30, 2025

Main branch | Deploy preview

This removes our usage of react-transition-group. We were only using it for the horizontal slide-in animation that occurs on the home page when we have a WebChannel and detect that the profiler button is in the toolbar.

@mstange mstange force-pushed the remove-transition-group branch 2 times, most recently from b982295 to b91bec5 Compare October 30, 2025 09:51
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.38%. Comparing base (2a7d07e) to head (e17e396).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5649   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         322      322           
  Lines       32099    32101    +2     
  Branches     8840     8849    +9     
=======================================
+ Hits        27408    27410    +2     
  Misses       4260     4260           
  Partials      431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange force-pushed the remove-transition-group branch from b91bec5 to 7018717 Compare April 9, 2026 14:04
@mstange mstange marked this pull request as ready for review April 9, 2026 14:06
@mstange mstange requested review from canova and fatadel as code owners April 9, 2026 14:06
Copy link
Copy Markdown
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mstange mstange enabled auto-merge April 10, 2026 13:40
@mstange mstange merged commit 23ab28e into firefox-devtools:main Apr 10, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants