[2.x] Add getPausedQueues() to QueueFactory for illuminate/queue v13.11+ compatibility#4672
Open
forumaker wants to merge 1 commit into
Open
[2.x] Add getPausedQueues() to QueueFactory for illuminate/queue v13.11+ compatibility#4672forumaker wants to merge 1 commit into
forumaker wants to merge 1 commit into
Conversation
…mpatibility illuminate/queue v13.11 added a call to getPausedQueues() in Worker.php, but Flarum's QueueFactory doesn't implement this method, causing the queue worker to crash with «Call to undefined method» and breaking all queued mail. This adds a no-op implementation — returns empty array — consistent with the existing isPaused() pattern.
forumaker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
illuminate/queue v13.11 added a call to getPausedQueues() in Worker.php, but Flarum's QueueFactory doesn't implement this method, causing the queue worker to crash with «Call to undefined method» and breaking all queued mail.
This adds a no-op implementation — returns empty array — consistent with the existing isPaused() pattern.
Changes proposed in this pull request:
Added
getPausedQueues(): arraymethod toQueueFactorywith a no-op implementation (returns empty array).Reviewers should focus on:
Whether returning an empty array is the correct behaviour, or if Flarum should implement actual queue pausing support in the future.