[camera_avfoundation] Remove unused Objective-C testing files#11240
[camera_avfoundation] Remove unused Objective-C testing files#11240cdeil wants to merge 1 commit intoflutter:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes unused Objective-C testing files (ExceptionCatcher.h, ExceptionCatcher.m, and RunnerTests-Bridging-Header.h) from the camera_avfoundation example. As part of this cleanup, references to these files are removed from the Xcode project file (project.pbxproj). Additionally, import Foundation statements are added to three Swift mock files that required it after the removal of the bridging header.
stuartmorgan-g
added
CICD
cdeil
force-pushed
the
rm-old-camera-avfoundation-objc-files
branch
from
0a2943e to
2465e4a
Compare
|
I wasn't sure if it's needed, but just in case I rebased against All tests are now green and I think this is ready. It just removes old test files, so doesn't require a CHANGELOG entry or version bump. |
stuartmorgan-g
added
the
autosubmit
Updates the iOS example app for `camera_avfoundation` to a Swift app. Rather than edit in place, this replaces the example app with a fresh copy to minimize drift from current template: - The existing ios/ directory was deleted - A new copy was created with `flutter create --platforms=ios --org=dev.flutter .` - The RunnerTest code was restored (other than unused files; see #11240), and the placeholder file removed. - The important Info.plist entries were restored. - The special logic to bypass app launch plugin registration during unit tests was moved from main.m, which no longer exists, to the delegate callback where registration would be done. I also did some minor test file cleanup I noticed while validating everything in Xcode again: - Remove some stale references to and usage of the `FLT` prefix (missed during Swift migrations). - Added some missing headers that local compilation complained about. This is part of an overall modernization of the example apps; most packages have already been converted to Swift examples. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
|
This removal ended up being incorporated into #11283; I was regenerating the project anyway in that PR, so I didn't re-include these files. Thanks for noticing this! |
stuartmorgan-g
removed
the
autosubmit
3 participants
Cleanup for flutter/flutter#119109 removing old unused files.
I ran into Pod-related error with the tests and saw that #11237 will resolve that, so this is just a draft that should wait for #11237 to land.
Pre-Review Checklist
[shared_preferences]///).