[compass_app] Scope LogoutViewModel to route builder — fix #2604#2819
Open
mozammal-hossain wants to merge 2 commits intoflutter:mainfrom
Open
[compass_app] Scope LogoutViewModel to route builder — fix #2604#2819mozammal-hossain wants to merge 2 commits intoflutter:mainfrom
mozammal-hossain wants to merge 2 commits intoflutter:mainfrom
Conversation
- Added LogoutViewModel to HomeScreen for managing user logout. - Updated HomeHeader to utilize the new LogoutViewModel. - Refactored HomeScreen tests to include LogoutViewModel initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem:
LogoutViewModelwas built insideHomeHeader.build(), so each rebuild could create a new instance and a newlogoutcommand. That does not match how other Compass view models are scoped (created in the GoRouter routebuilderand passed in), and it can affect an in-flight logout when the home screen rebuilds.Change: Create
LogoutViewModelonce in the/homeroute next toHomeViewModel, pass it throughHomeScreen→HomeHeader→LogoutButton, and remove inline construction inhome_title.dart. Updatehome_screen_test.dartto buildLogoutViewModelwith fakes and removeProviderwrappers that only supportedcontext.read()in the header.Result: Logout view model lifetime aligns with the home route; no visual or copy changes (screenshots not needed).
Fixes #2604
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.