ref(browser): send INP as span v2 envelope#21220
Draft
logaretm wants to merge 1 commit into
Draft
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3842126. Configure here.
|
|
||
| if (typeof value === 'number') { | ||
| return { type: Number.isInteger(value) ? 'integer' : 'double', value }; | ||
| } |
There was a problem hiding this comment.
Duplicated serialization diverges from core NaN handling
Low Severity
The new serializeSpanAttributeValue reimplements the core's getTypedAttributeValue (in attributes.ts) but omits the !Number.isNaN(value) guard. The core explicitly drops NaN numbers, while this code would produce { type: 'double', value: NaN }, which JSON-serializes to null. The broader streamedSpanJsonToSerializedSpan and serializeSpanAttributes functions also duplicate existing core utilities (spanUtils.ts and attributes.ts) with further divergences: the unit property from attribute objects is dropped, and links aren't serialized. Maintaining two parallel serialization paths risks inconsistencies when the core version is updated.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3842126. Configure here.
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/js-2628-drop-v1-web-vital-spans
branch
6 times, most recently
from
366b21d to
886135a
Compare
Co-Authored-By: Codex <codex@openai.com>
logaretm
force-pushed
the
awad/js-2628-drop-v1-web-vital-spans
branch
from
886135a to
f7159a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sends INP spans as v2 spans exclusively without a fallback path, this allows us to completely drop standalone v1 span implementation.
This is meant as a breaking change.