Open
Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Fallback returning empty array can wipe exception frames
- Added a check in symbolicate() to return null when sentryFrames.length === 0, preventing the truthy empty array from triggering replaceExceptionFramesInException and wiping original stack traces.
Or push these changes by commenting:
@cursor push 052a53a070
Preview (052a53a070)
diff --git a/packages/core/src/js/integrations/debugsymbolicator.ts b/packages/core/src/js/integrations/debugsymbolicator.ts
--- a/packages/core/src/js/integrations/debugsymbolicator.ts
+++ b/packages/core/src/js/integrations/debugsymbolicator.ts
@@ -92,6 +92,9 @@
);
const sentryFrames = await convertReactNativeFramesToSentryFrames(stackWithoutInternalCallsites);
+ if (sentryFrames.length === 0) {
+ return null;
+ }
return await fetchSourceContext(sentryFrames);
} catch (error) {
if (error instanceof Error) {This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
antonis
reviewed
Apr 1, 2026
Contributor
antonis
left a comment
There was a problem hiding this comment.
Other than the bot feedback LGTM
Co-authored-by: Claude <noreply@anthropic.com>
Sentry Build Distribution
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


📢 Type of change
📜 Description
Use Sentry React Native stack trace parser when
ReactNativeLibraries.Devtools?.parseErrorStackis not available.The change did no impact on stack trace grouping. Still, I opted to always prefer
ReactNativeLibraries.Devtools?.parseErrorStackto avoid any kind of break change.💡 Motivation and Context
In the near future,
ReactNativeLibraries.Devtools?.parseErrorStackwill no longer exist.💚 How did you test it?
Error with RN Parser https://sentry-sdks.sentry.io/issues/5005282269/events/a7874a2c8efb405caa1a81d0c0f3caab/?project=5428561
Error with Sentry Parser https://sentry-sdks.sentry.io/issues/5005282269/events/45fee3cad3cc43d3821a4121fa4ed80d/?project=5428561
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
Close #5943
I don't think this PR needs any changelog, since it gives no value to end users at the moment since they are not impacted by it.