Restores underlines to links in the content#3656
Open
aardrian wants to merge 1 commit intogithub:mainfrom
Open
Restores underlines to links in the content#3656aardrian wants to merge 1 commit intogithub:mainfrom
aardrian wants to merge 1 commit intogithub:mainfrom
Conversation
index.css has this code, which removes underlines from _all_ links on the page:
```
a {
color: #0366d6;
text-decoration: none;
}
```
This update reverts that for content links.
|
Thanks for reporting it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/assets/css/index.css has this code, which removes underlines from all links on the page:
I cannot find that file in the repo, so I've made my change to the custom.scss file.
This update reverts the underline removal for content links. Otherwise the links fail SC 1.4.1 Use of Color because, while the underline-on-hover style elsewhere suggests someone was trying to pass it via Technique G183, the contrast ratio between the blue link and black text is only 2.7:1.
This change fixes the WCAG violation and also provides demonstrably more usable links ("demonstrably" because I can point to research if needed).
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.