fix(gfxstream): check linear buffer size before copy-path transfers#128
Merged
Conversation
Due to timing issues (e.g., during rapid surface recreation or rotation), the system may fail to import zero-copy resources and fall back to the copy-path. If this occurs, `mLinear` might be empty, leading to a host-side null pointer dereference crash. This CL adds robust defensive checks to `ReadFromPipeToLinear`, `ReadFromBufferToLinear`, and `ReadFromColorBufferToLinear` to verify that `mLinear` is allocated and large enough before copying, safely returning `-EINVAL` otherwise. Bug: 511078953 Test: Verified host stability under forced fallback and rapid orientation transitions. Change-Id: I300d383ffb50ba7378518378cd5bde47d37541d9
Contributor
Author
|
@gurchetansingh can you review this PR? |
gurchetansingh
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to timing issues (e.g., during rapid surface recreation or rotation), the system may fail to import zero-copy resources and fall back to the copy-path. If this occurs,
mLinearmight be empty, leading to a host-side null pointer dereference crash.This CL adds robust defensive checks to
ReadFromPipeToLinear,ReadFromBufferToLinear, andReadFromColorBufferToLinearto verify thatmLinearis allocated and large enough before copying, safely returning-EINVALotherwise.Bug: 511078953
Test: Verified host stability under forced fallback and rapid orientation transitions.
Change-Id: I300d383ffb50ba7378518378cd5bde47d37541d9