Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ bazel_dep(name = "curl", version = "8.8.0.bcr.3")
bazel_dep(name = "opentelemetry-cpp", version = "1.24.0")
bazel_dep(name = "rules_proto", version = "7.1.0")
bazel_dep(name = "rules_python", version = "1.6.3")
bazel_dep(name = "rules_apple", version = "4.3.3")
bazel_dep(name = "rules_apple", version = "4.5.3")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The release notes for rules_apple v4.5.3, included in the pull request description, recommend specifying repo_name. To align with the official guidance for this dependency and prevent potential reference issues, please add repo_name = "build_bazel_rules_apple".

Suggested change
bazel_dep(name = "rules_apple", version = "4.5.3")
bazel_dep(name = "rules_apple", version = "4.5.3", repo_name = "build_bazel_rules_apple")

bazel_dep(name = "googletest", version = "1.17.0.bcr.2")

bazel_dep(name = "google_benchmark", version = "1.9.5", dev_dependency = True, repo_name = "com_google_benchmark")
Expand Down
Loading